[clangd] Drop ~destructor completions - rarely helpful and work inconsistently

llvm-svn: 323149

Author: sam-mccall

clang-tools-extra/clangd/CodeComplete.cpp

@@ -361,6 +361,10 @@ struct CompletionRecorder : public CodeCompleteConsumer {
           (Result.Availability == CXAvailability_NotAvailable ||
            Result.Availability == CXAvailability_NotAccessible))
         continue;
+      // Destructor completion is rarely useful, and works inconsistently.
+      // (s.^ completes ~string, but s.~st^ is an error).
+      if (dyn_cast_or_null<CXXDestructorDecl>(Result.Declaration))
+        continue;
       Results.push_back(Result);
     }
   }

clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp

@@ -461,7 +461,7 @@ TEST(CompletionTest, NoDuplicates) {
       {cls("Adapter")});
 
   // Make sure there are no duplicate entries of 'Adapter'.
-  EXPECT_THAT(Results.items, ElementsAre(Named("Adapter"), Named("~Adapter")));
+  EXPECT_THAT(Results.items, ElementsAre(Named("Adapter")));
 }
 
 TEST(CompletionTest, ScopedNoIndex) {