Skip to content

Commit d4006df

Browse files
committed
Switch to comparing messages, not percentage
1 parent dabda3b commit d4006df

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lldb/tools/lldb-dap/ProgressEvent.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,8 @@ ProgressEvent::Create(uint64_t progress_id, std::optional<StringRef> message,
8686
bool ProgressEvent::EqualsForIDE(const ProgressEvent &other) const {
8787
return m_progress_id == other.m_progress_id &&
8888
m_event_type == other.m_event_type &&
89-
// If we check the percentage of a non-deterministic event
90-
// we will basically never send the event, because N+1/Uint64_max
91-
// will always be an infinitesimally small change.
92-
(m_percentage != std::nullopt && m_percentage == other.m_percentage);
89+
m_percentage == other.m_percentage &&
90+
m_message == other.m_message;
9391
}
9492

9593
ProgressEventType ProgressEvent::GetEventType() const { return m_event_type; }

0 commit comments

Comments
 (0)