Fix a bug spotted in the review

s-barannikov · s-barannikov · commit d47572d9c624 · 2023-10-09T06:22:50.000+03:00
diff --git a/llvm/lib/Target/Sparc/SparcInstrInfo.td b/llvm/lib/Target/Sparc/SparcInstrInfo.td
@@ -222,6 +222,7 @@ def calltarget : Operand<i32> {
 }
 
 def simm13Op : Operand<iPTR> {
+  let OperandType = "OPERAND_IMMEDIATE";
   let DecoderMethod = "DecodeSIMM13";
   let EncoderMethod = "getSImm13OpValue";
 }
@@ -835,7 +836,7 @@ let Defs = [ICC], hasPostISelHook = true in
 let Uses = [ICC] in
   defm SUBC   : F3_12np <"subx", 0b001100>;
 
-def : Pat<(SPcmpicc i32:$lhs, i32:$rhs), (SUBCCri $lhs, $rhs)>;
+def : Pat<(SPcmpicc i32:$lhs, i32:$rhs), (SUBCCrr $lhs, $rhs)>;
 def : Pat<(SPcmpicc i32:$lhs, (i32 simm13:$rhs)), (SUBCCri $lhs, imm:$rhs)>;
 
 // Section B.18 - Multiply Instructions, p. 113

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,7 @@ def calltarget : Operand<i32> {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`def simm13Op : Operand<iPTR> {`
	`225`	`+ let OperandType = "OPERAND_IMMEDIATE";`
`225`	`226`	`let DecoderMethod = "DecodeSIMM13";`
`226`	`227`	`let EncoderMethod = "getSImm13OpValue";`
`227`	`228`	`}`
`@@ -835,7 +836,7 @@ let Defs = [ICC], hasPostISelHook = true in`
`835`	`836`	`let Uses = [ICC] in`
`836`	`837`	`defm SUBC : F3_12np <"subx", 0b001100>;`
`837`	`838`
`838`		`-def : Pat<(SPcmpicc i32:$lhs, i32:$rhs), (SUBCCri $lhs, $rhs)>;`
	`839`	`+def : Pat<(SPcmpicc i32:$lhs, i32:$rhs), (SUBCCrr $lhs, $rhs)>;`
`839`	`840`	`def : Pat<(SPcmpicc i32:$lhs, (i32 simm13:$rhs)), (SUBCCri $lhs, imm:$rhs)>;`
`840`	`841`
`841`	`842`	`// Section B.18 - Multiply Instructions, p. 113`