Skip to content

Commit d674f45

Browse files
[Transforms] Remove extraneous ArrayRef (NFC) (#89535)
We don't need to create these instances of ArrayRef because ConstantDataVector::get takes ArrayRef, and ArrayRef can be implicitly constructed from C arrays.
1 parent 6309440 commit d674f45

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3201,8 +3201,7 @@ Value *DFSanVisitor::makeAddAcquireOrderingTable(IRBuilder<> &IRB) {
32013201
OrderingTable[(int)AtomicOrderingCABI::seq_cst] =
32023202
(int)AtomicOrderingCABI::seq_cst;
32033203

3204-
return ConstantDataVector::get(IRB.getContext(),
3205-
ArrayRef(OrderingTable, NumOrderings));
3204+
return ConstantDataVector::get(IRB.getContext(), OrderingTable);
32063205
}
32073206

32083207
void DFSanVisitor::visitLibAtomicLoad(CallBase &CB) {
@@ -3245,8 +3244,7 @@ Value *DFSanVisitor::makeAddReleaseOrderingTable(IRBuilder<> &IRB) {
32453244
OrderingTable[(int)AtomicOrderingCABI::seq_cst] =
32463245
(int)AtomicOrderingCABI::seq_cst;
32473246

3248-
return ConstantDataVector::get(IRB.getContext(),
3249-
ArrayRef(OrderingTable, NumOrderings));
3247+
return ConstantDataVector::get(IRB.getContext(), OrderingTable);
32503248
}
32513249

32523250
void DFSanVisitor::visitLibAtomicStore(CallBase &CB) {

llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2131,8 +2131,7 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
21312131
OrderingTable[(int)AtomicOrderingCABI::seq_cst] =
21322132
(int)AtomicOrderingCABI::seq_cst;
21332133

2134-
return ConstantDataVector::get(IRB.getContext(),
2135-
ArrayRef(OrderingTable, NumOrderings));
2134+
return ConstantDataVector::get(IRB.getContext(), OrderingTable);
21362135
}
21372136

21382137
AtomicOrdering addAcquireOrdering(AtomicOrdering a) {
@@ -2166,8 +2165,7 @@ struct MemorySanitizerVisitor : public InstVisitor<MemorySanitizerVisitor> {
21662165
OrderingTable[(int)AtomicOrderingCABI::seq_cst] =
21672166
(int)AtomicOrderingCABI::seq_cst;
21682167

2169-
return ConstantDataVector::get(IRB.getContext(),
2170-
ArrayRef(OrderingTable, NumOrderings));
2168+
return ConstantDataVector::get(IRB.getContext(), OrderingTable);
21712169
}
21722170

21732171
// ------------------- Visitors.

0 commit comments

Comments
 (0)