[llvm] Adopt WithMarkup in the ARM backend (#65561)

JDevlieghere · web-flow · commit da81b1be44d5 · 2023-09-12T15:14:52.000-07:00
Adopt the new markup overload, introduced in 77d1032, in the ARM backend. This commit completes the migration and removes the old overload.
diff --git a/llvm/include/llvm/MC/MCInstPrinter.h b/llvm/include/llvm/MC/MCInstPrinter.h
@@ -154,9 +154,6 @@ class MCInstPrinter {
 
   WithMarkup markup(raw_ostream &OS, Markup M) const;
 
-  /// Utility functions to make adding mark ups simpler.
-  StringRef markup(StringRef s) const;
-
   bool getPrintImmHex() const { return PrintImmHex; }
   void setPrintImmHex(bool Value) { PrintImmHex = Value; }
 
diff --git a/llvm/lib/MC/MCInstPrinter.cpp b/llvm/lib/MC/MCInstPrinter.cpp
@@ -170,14 +170,6 @@ const char *MCInstPrinter::matchAliasPatterns(const MCInst *MI,
   return M.AsmStrings.data() + AsmStrOffset;
 }
 
-/// Utility functions to make adding mark ups simpler.
-StringRef MCInstPrinter::markup(StringRef s) const {
-  if (getUseMarkup())
-    return s;
-  else
-    return "";
-}
-
 // For asm-style hex (e.g. 0ffh) the first digit always has to be a number.
 static bool needsLeadingZero(uint64_t Value)
 {
diff --git a/llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp b/llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp

Original file line number	Diff line number	Diff line change
`@@ -170,14 +170,6 @@ const char MCInstPrinter::matchAliasPatterns(const MCInst MI,`
`170`	`170`	`return M.AsmStrings.data() + AsmStrOffset;`
`171`	`171`	`}`
`172`	`172`
`173`		`-/// Utility functions to make adding mark ups simpler.`
`174`		`-StringRef MCInstPrinter::markup(StringRef s) const {`
`175`		`- if (getUseMarkup())`
`176`		`- return s;`
`177`		`- else`
`178`		`- return "";`
`179`		`-}`
`180`		`-`
`181`	`173`	`// For asm-style hex (e.g. 0ffh) the first digit always has to be a number.`
`182`	`174`	`static bool needsLeadingZero(uint64_t Value)`
`183`	`175`	`{`