[libc++][test] Fix a logical mistake introduced by #77058 (#77867)

yingcong-wu · web-flow · commit dc1ae8378926 · 2024-01-12T17:48:34.000+01:00
A logical mistake is made in #77058, we should try to find a new file path for socket creation when the path's length generated is bigger than the socket length limit.
diff --git a/libcxx/test/support/filesystem_test_helper.h b/libcxx/test/support/filesystem_test_helper.h
@@ -330,7 +330,7 @@ struct scoped_test_env
 // Android platform warns about tmpnam, since the problem does not appear
 // on Android, let's not apply it for Android.
 #  if !defined(__ANDROID__)
-    if (file.size() <= sizeof(address.sun_path)) {
+    if (file.size() > sizeof(address.sun_path)) {
       file = std::tmpnam(nullptr);
     }
 #  endif

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ struct scoped_test_env`
`330`	`330`	`// Android platform warns about tmpnam, since the problem does not appear`
`331`	`331`	`// on Android, let's not apply it for Android.`
`332`	`332`	`# if !defined(__ANDROID__)`
`333`		`- if (file.size() <= sizeof(address.sun_path)) {`
	`333`	`+ if (file.size() > sizeof(address.sun_path)) {`
`334`	`334`	`file = std::tmpnam(nullptr);`
`335`	`335`	`}`
`336`	`336`	`# endif`