Imply --verify instea of warn, better error message

Author: Kevin Frei

llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp

@@ -2040,7 +2040,7 @@ void DWARFVerifier::summarize() {
     std::error_code EC;
     raw_fd_ostream JsonStream(DumpOpts.JsonSummaryFile, EC, sys::fs::OF_Text);
     if (EC) {
-      error() << "error opening aggregate error json file '"
+      error() << "unable to open json summary file '"
               << DumpOpts.JsonSummaryFile << "' for writing: " << EC.message()
               << '\n';
       return;

llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

@@ -840,10 +840,10 @@ int main(int argc, char **argv) {
                           "-verbose is currently not supported";
     return 1;
   }
-  if (!Verify && ErrorDetails != Unspecified)
-    WithColor::warning() << "-error-detail has no affect without -verify";
-  if (!Verify && !JsonSummaryFile.empty())
-    WithColor::warning() << "-json-summary-file has no affect without -verify";
+  // -error-detail and -json-summary-file both imply -verify
+  if (ErrorDetails != Unspecified || !JsonSummaryFile.empty()) {
+    Verify = true;
+  }
 
   std::error_code EC;
   ToolOutputFile OutputFile(OutputFilename, EC, sys::fs::OF_TextWithCRLF);