Skip to content

Commit e412325

Browse files
committed
[libc] Fix missing default value for errno config
Summary: The configs all need default values which targets then override. This one was an empty string which made the logic report an error. The only reason it wasn't a build failure was because of a stray `:`.
1 parent e0649a5 commit e412325

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

libc/cmake/modules/LibcConfig.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ function(load_libc_config config_file)
113113
message(FATAL_ERROR ${json_error})
114114
endif()
115115
if(NOT DEFINED ${opt_name})
116-
message(FATAL_ERROR: " Option ${opt_name} defined in ${config_file} is invalid.")
116+
message(FATAL_ERROR " Option ${opt_name} defined in ${config_file} is invalid.")
117117
endif()
118118
if(ARGN)
119119
list(FIND ARGN ${opt_name} optname_exists)

libc/config/config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"errno": {
33
"LIBC_CONF_ERRNO_MODE": {
4-
"value": "",
4+
"value": "LIBC_ERRNO_MODE_THREAD_LOCAL",
55
"doc": "The implementation used for errno, acceptable values are LIBC_ERRNO_MODE_UNDEFINED, LIBC_ERRNO_MODE_THREAD_LOCAL, LIBC_ERRNO_MODE_SHARED, LIBC_ERRNO_MODE_EXTERNAL, and LIBC_ERRNO_MODE_SYSTEM."
66
}
77
},

0 commit comments

Comments
 (0)