Skip to content

Commit e61de2c

Browse files
committed
Fix null pointer dereference in logging in mlir TransformOps
1 parent ca4a405 commit e61de2c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

mlir/lib/Dialect/Transform/IR/TransformOps.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -648,13 +648,14 @@ LogicalResult transform::ApplyConversionPatternsOp::verify() {
648648
if (!llvm::hasSingleElement(typeConverterRegion.front()))
649649
return emitOpError()
650650
<< "expected exactly one op in default type converter region";
651-
auto typeConverterOp = dyn_cast<transform::TypeConverterBuilderOpInterface>(
652-
&typeConverterRegion.front().front());
651+
652+
Operation *maybeTypeConverter = &typeConverterRegion.front().front();
653+
auto typeConverterOp = dyn_cast<transform::TypeConverterBuilderOpInterface>(maybeTypeConverter);
653654
if (!typeConverterOp) {
654655
InFlightDiagnostic diag = emitOpError()
655656
<< "expected default converter child op to "
656657
"implement TypeConverterBuilderOpInterface";
657-
diag.attachNote(typeConverterOp->getLoc()) << "op without interface";
658+
diag.attachNote(maybeTypeConverter->getLoc()) << "op without interface";
658659
return diag;
659660
}
660661
// Check default type converter type.

0 commit comments

Comments
 (0)