Skip to content

Commit f057130

Browse files
committed
[lldb] Remove commented-out Platform::FindPlugin (NFC)
1 parent f60f7b4 commit f057130

File tree

2 files changed

+0
-49
lines changed

2 files changed

+0
-49
lines changed

lldb/include/lldb/Target/Platform.h

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,6 @@ class Platform : public PluginInterface {
108108
static ArchSpec GetAugmentedArchSpec(Platform *platform,
109109
llvm::StringRef triple);
110110

111-
/// Find a platform plugin for a given process.
112-
///
113-
/// Scans the installed Platform plug-ins and tries to find an instance that
114-
/// can be used for \a process
115-
///
116-
/// \param[in] process
117-
/// The process for which to try and locate a platform
118-
/// plug-in instance.
119-
///
120-
/// \param[in] plugin_name
121-
/// An optional name of a specific platform plug-in that
122-
/// should be used. If nullptr, pick the best plug-in.
123-
// static lldb::PlatformSP
124-
// FindPlugin (Process *process, ConstString plugin_name);
125-
126111
/// Set the target's executable based off of the existing architecture
127112
/// information in \a target given a path to an executable \a exe_file.
128113
///

lldb/source/Target/Platform.cpp

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -161,40 +161,6 @@ Platform::LocateExecutableScriptingResources(Target *target, Module &module,
161161
return FileSpecList();
162162
}
163163

164-
// PlatformSP
165-
// Platform::FindPlugin (Process *process, ConstString plugin_name)
166-
//{
167-
// PlatformCreateInstance create_callback = nullptr;
168-
// if (plugin_name)
169-
// {
170-
// create_callback =
171-
// PluginManager::GetPlatformCreateCallbackForPluginName (plugin_name);
172-
// if (create_callback)
173-
// {
174-
// ArchSpec arch;
175-
// if (process)
176-
// {
177-
// arch = process->GetTarget().GetArchitecture();
178-
// }
179-
// PlatformSP platform_sp(create_callback(process, &arch));
180-
// if (platform_sp)
181-
// return platform_sp;
182-
// }
183-
// }
184-
// else
185-
// {
186-
// for (uint32_t idx = 0; (create_callback =
187-
// PluginManager::GetPlatformCreateCallbackAtIndex(idx)) != nullptr;
188-
// ++idx)
189-
// {
190-
// PlatformSP platform_sp(create_callback(process, nullptr));
191-
// if (platform_sp)
192-
// return platform_sp;
193-
// }
194-
// }
195-
// return PlatformSP();
196-
//}
197-
198164
Status Platform::GetSharedModule(
199165
const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp,
200166
const FileSpecList *module_search_paths_ptr,

0 commit comments

Comments
 (0)