Skip to content

Commit f113229

Browse files
JMazurkiewiczJMazurkiewicz
committed
[libc++] Implement views::join_with
* Partially implements P2441R2: `views::join_with` (https://wg21.link/P2441R2): * `views::join_with` cannot be used in constant expression because P2231R1 hasn't been implemented, * Feature test macro `__cpp_lib_ranges_join_with` is not included, * Completes implementation of P2711R1: "Making multi-param constructors of views explicit" (https://wg21.link/P2711R1), * Implements `[range.join.with.*]` parts of P2770R0: "Stashing stashing iterators for proper flattening" (https://wg21.link/P2770R0), * Renames `test/libcxx/ranges/range.adaptors/range.adaptor.tuple` directory to `test/libcxx/ranges/range.adaptors/range.adaptor.helpers` to match the standard: http://eel.is/c++draft/range.adaptor.helpers (this change happened in P2770R0, see point 3 of wording). * Adds `__ranges/helpers.h` file for helper functions.
1 parent 4a351ef commit f113229

File tree

29 files changed

+1897
-9
lines changed

29 files changed

+1897
-9
lines changed

‎libcxx/docs/ReleaseNotes/18.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Implemented Papers
4242
- P2497R0 - Testing for success or failure of ``<charconv>`` functions
4343
- P2697R1 - Interfacing ``bitset`` with ``string_view``
4444
- P2443R1 - ``views::chunk_by``
45+
- P2711R1 - Making multi-param constructors of ``views`` ``explicit``
4546

4647
Improvements and New Features
4748
-----------------------------

‎libcxx/docs/Status/Cxx23.rst

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ Paper Status
4545
.. [#note-P1413R3] P1413R3: ``std::aligned_storage_t`` and ``std::aligned_union_t`` are marked deprecated, but
4646
clang doesn't issue a diagnostic for deprecated using template declarations.
4747
.. [#note-P2520R0] P2520R0: Libc++ implemented this paper as a DR in C++20 as well.
48-
.. [#note-P2711R1] P2711R1: ``join_with_view`` hasn't been done yet since this type isn't implemented yet.
48+
.. [#note-P2441R2] P2441R2: ``views::join_with`` cannot be used in constant expressions (depends on P2231R1). Feature test macro is not defined.
49+
.. [#note-P2770R0] P2770R0: ``views::join_with`` part only.
4950
.. [#note-P2693R1] P2693R1: The formatter for ``std::thread::id`` is implemented.
5051
The formatter for ``stacktrace`` is not implemented, since ``stacktrace`` is
5152
not implemented yet.
@@ -63,4 +64,4 @@ Library Working Group Issues Status
6364
.. note::
6465

6566
.. [#note-LWG3750] LWG3750 Only ``__cpp_lib_format_ranges`` is fully implemented.
66-
.. [#note-LWG3798] LWG3798: ``join_with_view``, ``zip_transform_view``, and ``adjacent_transform_view`` haven't been done yet since these types aren't implemented yet.
67+
.. [#note-LWG3798] LWG3798: ``zip_transform_view`` and ``adjacent_transform_view`` haven't been done yet since these types aren't implemented yet.

‎libcxx/docs/Status/Cxx23Papers.csv

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"`P2273R3 <https://wg21.link/P2273R3>`__","LWG","Making ``std::unique_ptr`` constexpr","February 2022","|Complete|","16.0"
4848
"`P2387R3 <https://wg21.link/P2387R3>`__","LWG","Pipe support for user-defined range adaptors","February 2022","","","|ranges|"
4949
"`P2440R1 <https://wg21.link/P2440R1>`__","LWG","``ranges::iota``, ``ranges::shift_left`` and ``ranges::shift_right``","February 2022","","","|ranges|"
50-
"`P2441R2 <https://wg21.link/P2441R2>`__","LWG","``views::join_with``","February 2022","","","|ranges|"
50+
"`P2441R2 <https://wg21.link/P2441R2>`__","LWG","``views::join_with``","February 2022","|Partial| [#note-P2441R2]_","","|ranges|"
5151
"`P2442R1 <https://wg21.link/P2442R1>`__","LWG","Windowing range adaptors: ``views::chunk`` and ``views::slide``","February 2022","","","|ranges|"
5252
"`P2443R1 <https://wg21.link/P2443R1>`__","LWG","``views::chunk_by``","February 2022","|Complete|","18.0","|ranges|"
5353
"","","","","","",""
@@ -104,9 +104,9 @@
104104
"`P2708R1 <https://wg21.link/P2708R1>`__","LWG", "No Further Fundamentals TSes", "November 2022","|Nothing to do|","",""
105105
"","","","","","",""
106106
"`P0290R4 <https://wg21.link/P0290R4>`__","LWG", "``apply()`` for ``synchronized_value<T>``","February 2023","","","|concurrency TS|"
107-
"`P2770R0 <https://wg21.link/P2770R0>`__","LWG", "Stashing stashing ``iterators`` for proper flattening","February 2023","","","|ranges|"
107+
"`P2770R0 <https://wg21.link/P2770R0>`__","LWG", "Stashing stashing ``iterators`` for proper flattening","February 2023","|Partial| [#note-P2770R0]_","","|ranges|"
108108
"`P2164R9 <https://wg21.link/P2164R9>`__","LWG", "``views::enumerate``","February 2023","","","|ranges|"
109-
"`P2711R1 <https://wg21.link/P2711R1>`__","LWG", "Making multi-param constructors of ``views`` ``explicit``","February 2023","|Partial| [#note-P2711R1]_","","|ranges|"
109+
"`P2711R1 <https://wg21.link/P2711R1>`__","LWG", "Making multi-param constructors of ``views`` ``explicit``","February 2023","|Complete|","18.0","|ranges|"
110110
"`P2609R3 <https://wg21.link/P2609R3>`__","LWG", "Relaxing Ranges Just A Smidge","February 2023","","","|ranges|"
111111
"`P2713R1 <https://wg21.link/P2713R1>`__","LWG", "Escaping improvements in ``std::format``","February 2023","","","|format|"
112112
"`P2675R1 <https://wg21.link/P2675R1>`__","LWG", "``format``'s width estimation is too approximate and not forward compatible","February 2023","|Complete|","17.0","|format|"

‎libcxx/docs/Status/RangesMajorFeatures.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@ Standard,Name,Assignee,CL,Status
22
C++23,`ranges::to <https://wg21.link/P1206R7>`_,Konstantin Varlamov,`D142335 <https://reviews.llvm.org/D142335>`_,Complete
33
C++23,`Pipe support for user-defined range adaptors <https://wg21.link/P2387R3>`_,Unassigned,No patch yet,Not started
44
C++23,`Formatting Ranges <https://wg21.link/P2286R8>`_,Mark de Wever,Various,Complete
5+
C++23,`Stashing stashing iterators for proper flattening <https://wg21.link/P2770R0>`_,Jakub Mazurkiewicz,`GitHub #65536 <https://github.com/llvm/llvm-project/pull/65536>`_,In progress

‎libcxx/docs/Status/RangesViews.csv

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ C++23,`zip <https://wg21.link/P2321R2>`_,Hui Xie,`D122806 <https://llvm.org/D122
2828
C++23,`zip_transform <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started
2929
C++23,`adjacent <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started
3030
C++23,`adjacent_transform <https://wg21.link/P2321R2>`_,Hui Xie,No patch yet,Not started
31-
C++23,`join_with <https://wg21.link/P2441R2>`_,Unassigned,No patch yet,Not started
31+
C++23,`join_with <https://wg21.link/P2441R2>`_,Jakub Mazurkiewicz,`GitHub #65536 <https://github.com/llvm/llvm-project/pull/65536>`_,✅
3232
C++23,`slide <https://wg21.link/P2442R1>`_,Unassigned,No patch yet,Not started
3333
C++23,`chunk <https://wg21.link/P2442R1>`_,Unassigned,No patch yet,Not started
34-
C++23,`chunk_by <https://wg21.link/P2443R1>`_,Jakub Mazurkiewicz,`D144767 <https://llvm.org/D144767>`,✅
34+
C++23,`chunk_by <https://wg21.link/P2443R1>`_,Jakub Mazurkiewicz,`D144767 <https://llvm.org/D144767>`_,✅
3535
C++23,`as_const <https://wg21.link/P2278R4>`_,Unassigned,No patch yet,Not started
3636
C++23,`as_rvalue <https://wg21.link/P2446R2>`_,Nikolas Klauser,`D137637 <https://llvm.org/D137637>`_,✅
3737
C++23,`stride <https://wg21.link/P1899R3>`_,Hristo Hristov and Will Hawkins,`D156924 <https://llvm.org/D156924>`_,In Progress

‎libcxx/include/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,9 +620,11 @@ set(files
620620
__ranges/enable_view.h
621621
__ranges/filter_view.h
622622
__ranges/from_range.h
623+
__ranges/helpers.h
623624
__ranges/iota_view.h
624625
__ranges/istream_view.h
625626
__ranges/join_view.h
627+
__ranges/join_with_view.h
626628
__ranges/lazy_split_view.h
627629
__ranges/movable_box.h
628630
__ranges/non_propagating_cache.h

‎libcxx/include/__ranges/helpers.h

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
// -*- C++ -*-
2+
//===----------------------------------------------------------------------===//
3+
//
4+
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
5+
// See https://llvm.org/LICENSE.txt for license information.
6+
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
7+
//
8+
//===----------------------------------------------------------------------===//
9+
10+
#ifndef _LIBCPP___RANGES_HELPERS_H
11+
#define _LIBCPP___RANGES_HELPERS_H
12+
13+
#include <__config>
14+
15+
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
16+
# pragma GCC system_header
17+
#endif
18+
19+
_LIBCPP_PUSH_MACROS
20+
#include <__undef_macros>
21+
22+
_LIBCPP_BEGIN_NAMESPACE_STD
23+
24+
#if _LIBCPP_STD_VER >= 23
25+
26+
namespace ranges {
27+
template <class _Tp>
28+
_LIBCPP_HIDE_FROM_ABI constexpr _Tp& __as_lvalue(_Tp&& __t) {
29+
return static_cast<_Tp&>(__t);
30+
}
31+
} // namespace ranges
32+
33+
#endif // _LIBCPP_STD_VER >= 23
34+
35+
_LIBCPP_END_NAMESPACE_STD
36+
37+
_LIBCPP_POP_MACROS
38+
39+
#endif // _LIBCPP___RANGES_HELPERS_H

0 commit comments

Comments
 (0)