Skip to content

Commit f16e234

Browse files
authored
[InstCombine] Do not request non-splat vector support in code reviews (NFC) (#90709)
The InstCombine contributor guide already says: > Handle non-splat vector constants if doing so is free, but do > not add handling for them if it adds any additional complexity > to the code. This change strengthens this guideline to explicitly discourage asking (new) contributors to implement non-splat support during code reviews. Doing so will almost certainly increase the number of necessary review iterations, or result in outright contradictory review feedback, as different people are willing to accept a different degree of complexity for non-splat vector support.
1 parent 96aac67 commit f16e234

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

llvm/docs/InstCombineContributorGuide.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,3 +554,11 @@ guidelines.
554554
use of ValueTracking queries. Whether this makes sense depends on the case,
555555
but it's usually a good idea to only handle the constant pattern first, and
556556
then generalize later if it seems useful.
557+
558+
## Guidelines for reviewers
559+
560+
* Do not ask new contributors to implement non-splat vector support in code
561+
reviews. If you think non-splat vector support for a fold is both
562+
worthwhile and policy-compliant (that is, the handling would not result in
563+
any appreciable increase in code complexity), implement it yourself in a
564+
follow-up patch.

0 commit comments

Comments
 (0)