Skip to content

Commit f2259b4

Browse files
Kevin Freikevinfrei
Kevin Frei
authored andcommitted
Moved the @skipIf to each test, off of the class itself
1 parent ed4b77f commit f2259b4

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

lldb/test/API/debuginfod/Normal/TestDebuginfod.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919

2020

2121
# It looks like Linux-AArch64 doesn't support build-id's on the LLDB builtbots
22-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
2322
class DebugInfodTests(TestBase):
2423
# No need to try every flavor of debug inf.
2524
NO_DEBUG_INFO_TESTCASE = True
2625

26+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
2727
def test_normal_no_symbols(self):
2828
"""
2929
Validate behavior with no symbols or symbol locator.
@@ -32,6 +32,7 @@ def test_normal_no_symbols(self):
3232
test_root = self.config_test(["a.out"])
3333
self.try_breakpoint(False)
3434

35+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
3536
def test_normal_default(self):
3637
"""
3738
Validate behavior with symbols, but no symbol locator.
@@ -40,6 +41,7 @@ def test_normal_default(self):
4041
test_root = self.config_test(["a.out", "a.out.debug"])
4142
self.try_breakpoint(True)
4243

44+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
4345
def test_debuginfod_symbols(self):
4446
"""
4547
Test behavior with the full binary available from Debuginfod as
@@ -48,6 +50,7 @@ def test_debuginfod_symbols(self):
4850
test_root = self.config_test(["a.out"], "a.out.unstripped")
4951
self.try_breakpoint(True)
5052

53+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
5154
def test_debuginfod_executable(self):
5255
"""
5356
Test behavior with the full binary available from Debuginfod as
@@ -56,6 +59,7 @@ def test_debuginfod_executable(self):
5659
test_root = self.config_test(["a.out"], None, "a.out.unstripped")
5760
self.try_breakpoint(True)
5861

62+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
5963
def test_debuginfod_okd_symbols(self):
6064
"""
6165
Test behavior with the 'only-keep-debug' symbols available from Debuginfod.

lldb/test/API/debuginfod/SplitDWARF/TestDebuginfodDWP.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,25 +22,27 @@
2222

2323

2424
# It looks like Linux-AArch64 doesn't support build-id's on the LLDB builtbots
25-
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
2625
class DebugInfodDWPTests(TestBase):
2726
# No need to try every flavor of debug inf.
2827
NO_DEBUG_INFO_TESTCASE = True
2928

29+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
3030
def test_normal_stripped(self):
3131
"""
3232
Validate behavior with a stripped binary, no symbols or symbol locator.
3333
"""
3434
self.config_test(["a.out"])
3535
self.try_breakpoint(False)
3636

37+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
3738
def test_normal_stripped_split_with_dwp(self):
3839
"""
3940
Validate behavior with symbols, but no symbol locator.
4041
"""
4142
self.config_test(["a.out", "a.out.debug", "a.out.dwp"])
4243
self.try_breakpoint(True)
4344

45+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
4446
def test_normal_stripped_only_dwp(self):
4547
"""
4648
Validate behavior *with* dwp symbols only, but missing other symbols,
@@ -50,13 +52,15 @@ def test_normal_stripped_only_dwp(self):
5052
self.config_test(["a.out", "a.out.dwp"])
5153
self.try_breakpoint(False)
5254

55+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
5356
def test_debuginfod_dwp_from_service(self):
5457
"""
5558
Test behavior with the unstripped binary, and DWP from the service.
5659
"""
5760
self.config_test(["a.out.debug"], "a.out.dwp")
5861
self.try_breakpoint(True)
5962

63+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
6064
def test_debuginfod_both_symfiles_from_service(self):
6165
"""
6266
Test behavior with a stripped binary, with the unstripped binary and
@@ -65,6 +69,7 @@ def test_debuginfod_both_symfiles_from_service(self):
6569
self.config_test(["a.out"], "a.out.dwp", "a.out.unstripped")
6670
self.try_breakpoint(True)
6771

72+
@skipIf(oslist=no_match(["linux"]), archs=no_match(["i386", "x86_64"]))
6873
def test_debuginfod_both_okd_symfiles_from_service(self):
6974
"""
7075
Test behavior with both the only-keep-debug symbols and the dwp symbols

0 commit comments

Comments
 (0)