Skip to content

Commit f7463f6

Browse files
committed
Improve documentation
1 parent 723c913 commit f7463f6

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

clang-tools-extra/clang-tidy/cppcoreguidelines/UseEnumClassCheck.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313

1414
namespace clang::tidy::cppcoreguidelines {
1515

16-
/// Check for unscoped enums that are not contained in classes/structs.
17-
/// Suggest to use scoped enums (enum class) instead.
16+
/// Check for unscoped enums and suggest to use scoped enums (enum class).
17+
/// Optionally, ignore unscoped enums in classes via IgnoreUnscopedEnumsInClasses
1818
///
1919
/// For the user-facing documentation see:
2020
/// http://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/use-enum-class.html

clang-tools-extra/docs/ReleaseNotes.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ New checks
139139
- New :doc:`cppcoreguidelines-use-enum-class
140140
<clang-tidy/checks/cppcoreguidelines/use-enum-class>` check.
141141

142-
Finds plain non-class enum definitions that could use ``enum class``.
142+
Finds plain non-class ``enum`` definitions that could use ``enum class``.
143143

144144
New check aliases
145145
^^^^^^^^^^^^^^^^^

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/use-enum-class.rst

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
cppcoreguidelines-use-enum-class
44
=============================
55

6-
Scoped enums (enum class) should be preferred over unscoped enums:
7-
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class
6+
Finds plain non-class ``enum`` definitions that could use ``enum class``.
87

9-
Unscoped enums in classes are not reported since it is a well
10-
established pattern to limit the scope of plain enums.
8+
This check implements `Enum.3
9+
<https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class>`_
10+
from the C++ Core Guidelines."
1111

1212
Example:
1313

@@ -17,10 +17,15 @@ Example:
1717
enum class E {}; // OK
1818

1919
struct S {
20-
enum E {}; // OK, scope already limited
20+
enum E {}; // use "enum class E {};" instead
21+
// OK with option IgnoreUnscopedEnumsInClasses
2122
};
2223

2324
namespace N {
2425
enum E {}; // use "enum class E {};" instead
25-
// report since it is hard to detect how large the surrounding namespace is
2626
}
27+
28+
29+
.. option:: IgnoreUnscopedEnumsInClasses
30+
31+
When `true` (default is `false`), ignores unscoped ``enum`` declarations in classes.

0 commit comments

Comments
 (0)