Address review feedback

Author: Il-Capitano

lld/ELF/Thunks.cpp

@@ -1530,10 +1530,9 @@ static std::unique_ptr<Thunk> addThunkAArch64(Ctx &ctx, const InputSection &sec,
   bool mayNeedLandingPad =
       (ctx.arg.andFeatures & GNU_PROPERTY_AARCH64_FEATURE_1_BTI) &&
       !isAArch64BTILandingPad(ctx, s, a);
-  bool isPureCode = sec.getParent()->flags & SHF_AARCH64_PURECODE;
   if (ctx.arg.picThunk)
     return std::make_unique<AArch64ADRPThunk>(ctx, s, a, mayNeedLandingPad);
-  if (isPureCode)
+  if (sec.getParent()->flags & SHF_AARCH64_PURECODE)
     return std::make_unique<AArch64ABSXOLongThunk>(ctx, s, a,
                                                    mayNeedLandingPad);
   return std::make_unique<AArch64ABSLongThunk>(ctx, s, a, mayNeedLandingPad);

lld/test/ELF/Inputs/big-execute-only.s

@@ -1,7 +1,6 @@
 // REQUIRES: aarch64
-// RUN: llvm-mc -filetype=obj -triple=aarch64 %S/Inputs/big-execute-only.s -o %tbig.o
 // RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t.o
-// RUN: ld.lld %t.o %tbig.o -o %t
+// RUN: ld.lld %t.o --defsym big=0x1111222233334444 -o %t
 // RUN: llvm-objdump -d --no-show-raw-insn %t | FileCheck %s
 
 .section .text,"axy",@progbits,unique,0
@@ -11,12 +10,12 @@ _start:
 
 // CHECK: Disassembly of section .text:
 // CHECK-EMPTY:
-// CHECK-NEXT: <_start>:
-// CHECK-NEXT:    210120:       bl      0x210124
-// CHECK:      <__AArch64AbsXOLongThunk_big>:
-// CHECK-NEXT:    210124:       mov  x16, #0x4444
-// CHECK-NEXT:    210128:       movk x16, #0x3333, lsl #16
-// CHECK-NEXT:    21012c:       movk x16, #0x2222, lsl #32
-// CHECK-NEXT:    210130:       movk x16, #0x1111, lsl #48
-// CHECK-NEXT:    210134:       br   x16
+// CHECK-LABEL: <_start>:
+// CHECK-NEXT:     210120: bl      0x210124
+// CHECK-LABEL: <__AArch64AbsXOLongThunk_big>:
+// CHECK-NEXT:     210124: mov  x16, #0x4444
+// CHECK-NEXT:             movk x16, #0x3333, lsl #16
+// CHECK-NEXT:             movk x16, #0x2222, lsl #32
+// CHECK-NEXT:             movk x16, #0x1111, lsl #48
+// CHECK-NEXT:             br   x16
 

lld/test/ELF/aarch64-call26-thunk-execute-only.s

@@ -1,7 +1,6 @@
 // REQUIRES: aarch64
-// RUN: llvm-mc -filetype=obj -triple=aarch64 %S/Inputs/big-execute-only.s -o %tbig.o
 // RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t.o
-// RUN: ld.lld %t.o %tbig.o -o %t
+// RUN: ld.lld %t.o --defsym big=0x1111222233334444 -o %t
 // RUN: llvm-objdump -d --no-show-raw-insn %t | FileCheck %s
 
 .section .text,"axy",@progbits,unique,0
@@ -11,12 +10,12 @@ _start:
 
 // CHECK: Disassembly of section .text:
 // CHECK-EMPTY:
-// CHECK-NEXT: <_start>:
-// CHECK-NEXT:    210120:       b       0x210124
-// CHECK:      <__AArch64AbsXOLongThunk_big>:
-// CHECK-NEXT:    210124:       mov     x16, #0x4444
-// CHECK-NEXT:    210128:       movk    x16, #0x3333, lsl #16
-// CHECK-NEXT:    21012c:       movk    x16, #0x2222, lsl #32
-// CHECK-NEXT:    210130:       movk    x16, #0x1111, lsl #48
-// CHECK-NEXT:    210134:       br      x16
+// CHECK-LABEL: <_start>:
+// CHECK-NEXT:     210120: b       0x210124
+// CHECK-LABEL: <__AArch64AbsXOLongThunk_big>:
+// CHECK-NEXT:     210124: mov     x16, #0x4444
+// CHECK-NEXT:             movk    x16, #0x3333, lsl #16
+// CHECK-NEXT:             movk    x16, #0x2222, lsl #32
+// CHECK-NEXT:             movk    x16, #0x1111, lsl #48
+// CHECK-NEXT:             br      x16