fix

Author: HerrCai0907

clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.cpp

@@ -1,5 +1,4 @@
-//===--- UseInternalLinkageCheck.cpp - clang-tidy
-//---------------------------------===//
+//===--- UseInternalLinkageCheck.cpp - clang-tidy--------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
@@ -13,6 +12,7 @@
 #include "clang/ASTMatchers/ASTMatchers.h"
 #include "clang/ASTMatchers/ASTMatchersMacros.h"
 #include "clang/Basic/Specifiers.h"
+#include "llvm/ADT/STLExtras.h"
 
 using namespace clang::ast_matchers;
 
@@ -27,11 +27,10 @@ AST_POLYMORPHIC_MATCHER(isFirstDecl,
 }
 
 AST_MATCHER(Decl, isInMainFile) {
-  for (const Decl *D : Node.redecls())
-    if (!Finder->getASTContext().getSourceManager().isInMainFile(
-            D->getLocation()))
-      return false;
-  return true;
+  return llvm::all_of(Node.redecls(), [&](const Decl *D) {
+    return Finder->getASTContext().getSourceManager().isInMainFile(
+        D->getLocation());
+  });
 }
 
 AST_POLYMORPHIC_MATCHER(isExternStorageClass,
@@ -62,9 +61,8 @@ void UseInternalLinkageCheck::registerMatchers(MatchFinder *Finder) {
 }
 
 static constexpr StringRef Message =
-    "%0 %1 can be internal linkage, "
-    "marking as static or using anonymous namespace can avoid external "
-    "linkage.";
+    "%0 %1 can be can be made static or moved into an anonymous namespace "
+    "to enforce internal linkage.";
 
 void UseInternalLinkageCheck::check(const MatchFinder::MatchResult &Result) {
   if (const auto *FD = Result.Nodes.getNodeAs<FunctionDecl>("fn")) {

clang-tools-extra/clang-tidy/misc/UseInternalLinkageCheck.h

@@ -13,7 +13,8 @@
 
 namespace clang::tidy::misc {
 
-/// Detects variable and function can be marked as static.
+/// Detects variables and functions that can be marked as static or moved into
+/// an anonymous namespace to enforce internal linkage.
 ///
 /// For the user-facing documentation see:
 /// http://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html

clang-tools-extra/docs/ReleaseNotes.rst

@@ -145,17 +145,18 @@ New checks
   Finds initializer lists for aggregate types that could be
   written as designated initializers instead.
 
+- New :doc:`misc-use-internal-linkage
+  <clang-tidy/checks/misc/use-internal-linkage>` check.
+
+  Detects variables and functions that can be marked as static or moved into
+  an anonymous namespace to enforce internal linkage.
+
 - New :doc:`readability-enum-initial-value
   <clang-tidy/checks/readability/enum-initial-value>` check.
 
   Enforces consistent style for enumerators' initialization, covering three
   styles: none, first only, or all initialized explicitly.
 
-- New :doc:`misc-use-internal-linkage
-  <clang-tidy/checks/misc/use-internal-linkage>` check.
-
-  Detects variable and function can be marked as static.
-
 - New :doc:`readability-math-missing-parentheses
   <clang-tidy/checks/readability/math-missing-parentheses>` check.
 

clang-tools-extra/docs/clang-tidy/checks/misc/use-internal-linkage.rst

@@ -3,12 +3,12 @@
 misc-use-internal-linkage
 =========================
 
-Detects variable and function can be marked as static.
+Detects variables and functions that can be marked as static or moved into
+an anonymous namespace to enforce internal linkage.
 
 Static functions and variables are scoped to a single file. Marking functions
 and variables as static helps to better remove dead code. In addition, it gives
-the compiler more information and can help compiler make more aggressive
-optimizations.
+the compiler more information and allows for more aggressive optimizations.
 
 Example: