Skip to content

Commit fb08913

Browse files
[SelectionDAG] Clean up some redundant setting of node flags (NFC) (#130307)
PR #130124 added a use of FlagInserter to the start of SelectionDAGLegalize::PromoteNode, making some of the places where we set flags be redundant, so remove them. The places where the setting of flags remains are in non-floating-point operations.
1 parent d4754db commit fb08913

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5283,7 +5283,6 @@ void SelectionDAGLegalize::PromoteNode(SDNode *Node) {
52835283
Tmp3 = DAG.getNode(ExtOp, dl, NVT, Node->getOperand(2));
52845284
// Perform the larger operation, then round down.
52855285
Tmp1 = DAG.getSelect(dl, NVT, Tmp1, Tmp2, Tmp3);
5286-
Tmp1->setFlags(Node->getFlags());
52875286
if (TruncOp != ISD::FP_ROUND)
52885287
Tmp1 = DAG.getNode(TruncOp, dl, Node->getValueType(0), Tmp1);
52895288
else
@@ -5412,8 +5411,7 @@ void SelectionDAGLegalize::PromoteNode(SDNode *Node) {
54125411
case ISD::FATAN2:
54135412
Tmp1 = DAG.getNode(ISD::FP_EXTEND, dl, NVT, Node->getOperand(0));
54145413
Tmp2 = DAG.getNode(ISD::FP_EXTEND, dl, NVT, Node->getOperand(1));
5415-
Tmp3 = DAG.getNode(Node->getOpcode(), dl, NVT, Tmp1, Tmp2,
5416-
Node->getFlags());
5414+
Tmp3 = DAG.getNode(Node->getOpcode(), dl, NVT, Tmp1, Tmp2);
54175415
Results.push_back(
54185416
DAG.getNode(ISD::FP_ROUND, dl, OVT, Tmp3,
54195417
DAG.getIntPtrConstant(0, dl, /*isTarget=*/true)));
@@ -5524,8 +5522,7 @@ void SelectionDAGLegalize::PromoteNode(SDNode *Node) {
55245522
case ISD::FSINCOS:
55255523
case ISD::FSINCOSPI: {
55265524
Tmp1 = DAG.getNode(ISD::FP_EXTEND, dl, NVT, Node->getOperand(0));
5527-
Tmp2 = DAG.getNode(Node->getOpcode(), dl, DAG.getVTList(NVT, NVT), Tmp1,
5528-
Node->getFlags());
5525+
Tmp2 = DAG.getNode(Node->getOpcode(), dl, DAG.getVTList(NVT, NVT), Tmp1);
55295526
Tmp3 = DAG.getIntPtrConstant(0, dl, /*isTarget=*/true);
55305527
for (unsigned ResNum = 0; ResNum < Node->getNumValues(); ResNum++)
55315528
Results.push_back(

0 commit comments

Comments
 (0)