Skip to content

Commit fd26f84

Browse files
authored
[mlir][gpu] Rename two misspelled pattern population functions (#109015)
1 parent 318d2f5 commit fd26f84

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

mlir/include/mlir/Dialect/GPU/Transforms/Passes.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,14 @@ void populateGpuAllReducePatterns(RewritePatternSet &patterns);
6666
/// Collect a set of patterns to break down subgroup_reduce ops into smaller
6767
/// ones supported by the target of `size <= maxShuffleBitwidth`, where `size`
6868
/// is the subgroup_reduce value bitwidth.
69-
void populateGpuBreakDownSubgrupReducePatterns(RewritePatternSet &patterns,
70-
unsigned maxShuffleBitwidth = 32,
71-
PatternBenefit benefit = 1);
69+
void populateGpuBreakDownSubgroupReducePatterns(
70+
RewritePatternSet &patterns, unsigned maxShuffleBitwidth = 32,
71+
PatternBenefit benefit = 1);
7272

7373
/// Collect a set of patterns to lower `gpu.subgroup_reduce` into `gpu.shuffle`
7474
/// ops over `shuffleBitwidth` scalar types. Assumes that the subgroup has
7575
/// `subgroupSize` lanes. Uses the butterfly shuffle algorithm.
76-
void populateGpuLowerSubgroupReduceToShufflePattenrs(
76+
void populateGpuLowerSubgroupReduceToShufflePatterns(
7777
RewritePatternSet &patterns, unsigned subgroupSize,
7878
unsigned shuffleBitwidth = 32, PatternBenefit benefit = 1);
7979

mlir/lib/Dialect/GPU/Transforms/SubgroupReduceLowering.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -346,15 +346,15 @@ struct VectorSubgroupReduceToShuffles final
346346
};
347347
} // namespace
348348

349-
void mlir::populateGpuBreakDownSubgrupReducePatterns(
349+
void mlir::populateGpuBreakDownSubgroupReducePatterns(
350350
RewritePatternSet &patterns, unsigned maxShuffleBitwidth,
351351
PatternBenefit benefit) {
352352
patterns.add<BreakDownSubgroupReduce>(patterns.getContext(),
353353
maxShuffleBitwidth, benefit);
354354
patterns.add<ScalarizeSingleElementReduce>(patterns.getContext(), benefit);
355355
}
356356

357-
void mlir::populateGpuLowerSubgroupReduceToShufflePattenrs(
357+
void mlir::populateGpuLowerSubgroupReduceToShufflePatterns(
358358
RewritePatternSet &patterns, unsigned subgroupSize,
359359
unsigned shuffleBitwidth, PatternBenefit benefit) {
360360
patterns.add<ScalarSubgroupReduceToShuffles, VectorSubgroupReduceToShuffles>(

mlir/test/lib/Dialect/GPU/TestGpuRewrite.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ struct TestGpuSubgroupReduceLoweringPass
7575

7676
// Since both pattern sets match on the same ops, set higher benefit to
7777
// perform fewer failing matches.
78-
populateGpuBreakDownSubgrupReducePatterns(patterns,
79-
/*maxShuffleBitwidth=*/32,
80-
PatternBenefit(2));
78+
populateGpuBreakDownSubgroupReducePatterns(patterns,
79+
/*maxShuffleBitwidth=*/32,
80+
PatternBenefit(2));
8181
if (expandToShuffles)
82-
populateGpuLowerSubgroupReduceToShufflePattenrs(
82+
populateGpuLowerSubgroupReduceToShufflePatterns(
8383
patterns, /*subgroupSize=*/32, /*shuffleBitwidth=*/32);
8484

8585
(void)applyPatternsAndFoldGreedily(getOperation(), std::move(patterns));

0 commit comments

Comments
 (0)