Skip to content

Commit fdbc408

Browse files
[LTO] Compare std::optional<ImportKind> directly with ImportKind (NFC) (#105561)
Note that: Opt == Val if and only (Opt && *Opt == Val) where: std::optional<T> Opt; T Val;
1 parent ec8fe7a commit fdbc408

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

llvm/lib/Transforms/IPO/FunctionImport.cpp

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1814,10 +1814,7 @@ Expected<bool> FunctionImporter::importFunctions(
18141814
continue;
18151815
auto GUID = F.getGUID();
18161816
auto MaybeImportType = getImportType(ImportGUIDs, GUID);
1817-
1818-
bool ImportDefinition =
1819-
(MaybeImportType &&
1820-
(*MaybeImportType == GlobalValueSummary::Definition));
1817+
bool ImportDefinition = MaybeImportType == GlobalValueSummary::Definition;
18211818

18221819
LLVM_DEBUG(dbgs() << (MaybeImportType ? "Is" : "Not")
18231820
<< " importing function"
@@ -1853,10 +1850,7 @@ Expected<bool> FunctionImporter::importFunctions(
18531850
continue;
18541851
auto GUID = GV.getGUID();
18551852
auto MaybeImportType = getImportType(ImportGUIDs, GUID);
1856-
1857-
bool ImportDefinition =
1858-
(MaybeImportType &&
1859-
(*MaybeImportType == GlobalValueSummary::Definition));
1853+
bool ImportDefinition = MaybeImportType == GlobalValueSummary::Definition;
18601854

18611855
LLVM_DEBUG(dbgs() << (MaybeImportType ? "Is" : "Not")
18621856
<< " importing global"
@@ -1876,10 +1870,7 @@ Expected<bool> FunctionImporter::importFunctions(
18761870
continue;
18771871
auto GUID = GA.getGUID();
18781872
auto MaybeImportType = getImportType(ImportGUIDs, GUID);
1879-
1880-
bool ImportDefinition =
1881-
(MaybeImportType &&
1882-
(*MaybeImportType == GlobalValueSummary::Definition));
1873+
bool ImportDefinition = MaybeImportType == GlobalValueSummary::Definition;
18831874

18841875
LLVM_DEBUG(dbgs() << (MaybeImportType ? "Is" : "Not")
18851876
<< " importing alias"

0 commit comments

Comments
 (0)