Apply suggestions from code review

Separate DSL and ESQL interface in the client.

Co-authored-by: Rye Biesemeyer <[email protected]>

Author: mashhurs

lib/logstash/filters/elasticsearch/client.rb

@@ -55,8 +55,12 @@ def initialize(logger, hosts, options = {})
         @client = ::Elasticsearch::Client.new(client_options)
       end
 
-      def search(params={}, query_type = 'dsl')
-        query_type == 'esql' ? @client.esql.query(params) : @client.search(params)
+      def search(params={})
+        @client.search(params)
+      end
+      
+      def esql_query(params={})
+        @client.esql.query(params)
       end
 
       def info

lib/logstash/filters/elasticsearch/esql_executor.rb

@@ -54,7 +54,7 @@ def resolve_parameters(event)
         def execute_query(client, params)
           # debug logs  may help to check what query shape the plugin is sending to ES
           @logger.debug("Executing ES|QL query", query: @query, params: params)
-          client.search({ body: { query: @query, params: params }, format: 'json', drop_null_columns: true }, 'esql')
+          client.esql_query({ body: { query: @query, params: params }, format: 'json', drop_null_columns: true }, 'esql')
         end
 
         def process_response(event, response)