[Imported] AC-941: Create unit test for Magento2\Less\ClassNamingSniff check (#38)

https://jira.corp.magento.com/browse/AC-941

Author: magento-engcom-team

Magento2/Sniffs/Less/ClassNamingSniff.php

@@ -21,10 +21,7 @@
  */
 class ClassNamingSniff implements Sniff
 {
-
-    const STRING_HELPER_CLASSES_PREFIX = '_';
-
-    const STRING_ALLOWED_UNDERSCORES = '__';
+    private const STRING_HELPER_CLASSES_PREFIX = '_';
 
     /**
      * A list of tokenizers this sniff supports.
@@ -62,7 +59,19 @@ public function process(File $phpcsFile, $stackPtr)
 
         $className = $tokens[$stackPtr + 1]['content'];
         if (preg_match_all('/[^a-z0-9\-_]/U', $className, $matches)) {
-            $phpcsFile->addError('Class name contains not allowed symbols', $stackPtr, 'NotAllowedSymbol', $matches);
+            $phpcsFile->addError(
+                'CSS class name does not follow class naming requirements: %s',
+                $stackPtr,
+                'NotAllowedSymbol',
+                [implode("", $matches[0])]
+            );
+        }
+        if (strpos($className, self::STRING_HELPER_CLASSES_PREFIX, 2) !== false) {
+            $phpcsFile->addError(
+                'CSS class names should be separated with "-" (dash) instead of "_" (underscore)',
+                $stackPtr,
+                'NotAllowedSymbol'
+            );
         }
     }
 }

Magento2/Tests/Less/ClassNamingUnitTest.less

@@ -0,0 +1,32 @@
+// /**
+//  * Copyright © Magento, Inc. All rights reserved.
+//  * See COPYING.txt for license details.
+//  */
+
+.UPPERCASE {
+  background: red;
+}
+
+.Capital {
+  background: red;
+}
+
+.camelCase {
+  background: red;
+}
+
+.snake_case {
+  background: red;
+}
+
+._helper {
+  background: green;
+}
+
+.__another-helper {
+  background: green;
+}
+
+.category-title {
+  background: green;
+}

Magento2/Tests/Less/ClassNamingUnitTest.php

@@ -0,0 +1,30 @@
+<?php
+/**
+ * Copyright © Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento2\Tests\Less;
+
+class ClassNamingUnitTest extends AbstractLessSniffUnitTestCase
+{
+    /**
+     * @inheritdoc
+     */
+    public function getErrorList()
+    {
+        return [
+            6 => 1,
+            10 => 1,
+            14 => 1,
+            18 => 1
+        ];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList()
+    {
+        return [];
+    }
+}