Merge pull request #48 from magento-commerce/imported-magento-magento-coding-standard-238

[Imported] AC-943: Create unit test for Magento2\Less\ColourDefinitionSniff check

Author: svera

Magento2/Sniffs/Less/ColourDefinitionSniff.php

@@ -42,7 +42,7 @@ public function process(File $phpcsFile, $stackPtr)
 
         $variablePtr = $phpcsFile->findPrevious(T_ASPERAND, $stackPtr);
         if ((false === $variablePtr) || ($tokens[$stackPtr]['line'] !== $tokens[$variablePtr]['line'])) {
-            $phpcsFile->addError('Hexadecimal value should be used for variable', $stackPtr, 'NotInVariable');
+            $phpcsFile->addError('A variable should be used for a CSS colour', $stackPtr, 'NotInVariable');
         }
 
         $expected = strtolower($colour);

Magento2/Tests/Less/ColourDefinitionUnitTest.less

@@ -0,0 +1,25 @@
+// /**
+//  * Copyright © Magento, Inc. All rights reserved.
+//  * See COPYING.txt for license details.
+//  */
+
+@red: #aaaaaa;
+@blue: #00F;
+@green: #0f0;
+@purple: #abcdef;
+
+.my{
+  color: @red;
+}
+
+.foo {
+  color: #aaa;
+}
+
+.baz {
+  color: @blue;
+}
+
+.bar {
+  color: @green;
+}

Magento2/Tests/Less/ColourDefinitionUnitTest.php

@@ -0,0 +1,29 @@
+<?php
+/**
+ * Copyright © Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento2\Tests\Less;
+
+class ColourDefinitionUnitTest extends AbstractLessSniffUnitTestCase
+{
+    /**
+     * @inheritdoc
+     */
+    public function getErrorList()
+    {
+        return [
+            6 => 1,
+            7 => 1,
+            16 => 1,
+        ];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList()
+    {
+        return [];
+    }
+}