Merge pull request #52 from magento-commerce/imported-magento-magento-coding-standard-256

[Imported] Fix PHP Fatal error when docblock is invalid

Author: sivaschenko

Magento2/Sniffs/Annotation/MethodArgumentsSniff.php

@@ -609,8 +609,6 @@ public function process(File $phpcsFile, $stackPtr)
      * @param File $phpcsFile
      * @param array $paramPointers
      *
-     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
-     *
      * @see https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#format-consistency
      */
     private function validateFormattingConsistency(
@@ -626,7 +624,9 @@ private function validateFormattingConsistency(
             if (isset($paramPointers[$ptr])) {
                 $paramContent = $tokens[$paramPointers[$ptr] + 2]['content'];
                 $paramDefinition = $paramDefinitions[$ptr];
-                $argumentPositions[] = strpos($paramContent, $paramDefinition['paramName']);
+                if (isset($paramDefinition['paramName'])) {
+                    $argumentPositions[] = strpos($paramContent, $paramDefinition['paramName']);
+                }
                 $commentPositions[] = $paramDefinition['comment']
                     ? strrpos($paramContent, $paramDefinition['comment']) : null;
             }

Magento2/Tests/Annotation/MethodArgumentsUnitTest.inc

@@ -22,3 +22,14 @@ public function setExtensionAs(\Magento\Catalog\Api\Data\CategoryExtensionInterf
 {
     return $this->_setExtensionAttributes($extensionAttributes);
 }
+
+/**
+ * Short description of method
+ *
+ * @param int
+ * @return int
+ */
+public function invalidDocBlockShouldNotCauseFatalErrorInSniff(int $number): int
+{
+    return $number;
+}

Magento2/Tests/Annotation/MethodArgumentsUnitTest.php

@@ -16,10 +16,11 @@ public function getErrorList()
     {
         return [
             12 => 1,
-            21 => 1
+            21 => 1,
+            32 => 1,
         ];
     }
-    
+
     /**
      * @inheritdoc
      */