Skip to content

Commit 37de3a1

Browse files
authored
MQE-1015: Test Generation Error If Suite Has Action Group With 2+ Arguments
- fixed di.xml problem - added to existing suite generation tests
1 parent 5dc4c0d commit 37de3a1

File tree

4 files changed

+21
-0
lines changed

4 files changed

+21
-0
lines changed

dev/tests/verification/Resources/functionalSuiteHooks.txt

+2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ class functionalSuiteHooks extends \Codeception\GroupObject
5858
$createThis = DataObjectHandler::getInstance()->getObject("createThis");
5959
$this->create = new DataPersistenceHandler($createThis, [], $createFields);
6060
$this->create->createEntity();
61+
$webDriver->see("John", msq("uniqueData") . "John");
6162

6263
// reset configuration and close session
6364
$this->getModule('\Magento\FunctionalTestingFramework\Module\MagentoWebDriver')->_resetConfig();
@@ -95,6 +96,7 @@ class functionalSuiteHooks extends \Codeception\GroupObject
9596
$webDriver->_initializeSession();
9697
$webDriver->amOnPage("some.url");
9798
$webDriver->deleteEntityByUrl("deleteThis");
99+
$webDriver->see("John", msq("uniqueData") . "John");
98100

99101
// reset configuration and close session
100102
$this->getModule('\Magento\FunctionalTestingFramework\Module\MagentoWebDriver')->_resetConfig();

dev/tests/verification/TestModule/ActionGroup/BasicActionGroup.xml

+9
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,15 @@
1919
<see selector="{{SampleSection.oneParamElement('test1')}}" userInput="{{someArgument.firstname}}" stepKey="seeFirstName" />
2020
</actionGroup>
2121

22+
<actionGroup name="actionGroupWithTwoArguments">
23+
<arguments>
24+
<argument name="somePerson"/>
25+
<argument name="anotherPerson"/>
26+
</arguments>
27+
28+
<see selector="{{anotherPerson.firstname}}" userInput="{{somePerson.firstname}}" stepKey="seeFirstName" />
29+
</actionGroup>
30+
2231
<actionGroup name="actionGroupWithSingleParameterSelectorFromArgument">
2332
<arguments>
2433
<argument name="someArgument" defaultValue="ReplacementPerson" />

dev/tests/verification/_suite/functionalSuiteHooks.xml

+8
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,18 @@
1616
<createData entity="createThis" stepKey="create">
1717
<field key="someKey">dataHere</field>
1818
</createData>
19+
<actionGroup ref="actionGroupWithTwoArguments" stepKey="AC">
20+
<argument name="somePerson" value="simpleData"/>
21+
<argument name="anotherPerson" value="uniqueData"/>
22+
</actionGroup>
1923
</before>
2024
<after>
2125
<amOnPage url="some.url" stepKey="after"/>
2226
<deleteData url="deleteThis" stepKey="delete"/>
27+
<actionGroup ref="actionGroupWithTwoArguments" stepKey="AC">
28+
<argument name="somePerson" value="simpleData"/>
29+
<argument name="anotherPerson" value="uniqueData"/>
30+
</actionGroup>
2331
</after>
2432
</suite>
2533
</suites>

etc/di.xml

+2
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,7 @@
361361
<argument name="idAttributes" xsi:type="array">
362362
<item name="/suites/suite" xsi:type="string">name</item>
363363
<item name="/suites/suite/(before|after)/remove" xsi:type="string">keyForRemoval</item>
364+
<item name="/suites/suite/(before|after)/actionGroup/argument" xsi:type="string">name</item>
364365
<item name="/suites/suite/(before|after)/(actionGroup|&commonTestActions;)" xsi:type="string">stepKey</item>
365366
<item name="/suites/suite/(before|after)/createData/requiredEntity" xsi:type="string">createDataKey</item>
366367
<item name="/suites/suite/(before|after)/createData/field" xsi:type="string">key</item>
@@ -377,6 +378,7 @@
377378
<argument name="assocArrayAttributes" xsi:type="array">
378379
<item name="/suites/suite" xsi:type="string">name</item>
379380
<item name="/suites/suite/(before|after)/remove" xsi:type="string">keyForRemoval</item>
381+
<item name="/suites/suite/(before|after)/actionGroup/argument" xsi:type="string">name</item>
380382
<item name="/suites/suite/(before|after)/(actionGroup|&commonTestActions;)" xsi:type="string">stepKey</item>
381383
<item name="/suites/suite/(before|after)/createData/requiredEntity" xsi:type="string">createDataKey</item>
382384
<item name="/suites/suite/(before|after)/createData/field" xsi:type="string">key</item>

0 commit comments

Comments
 (0)