MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory. #162

- Reintroduced recursive_merge to prevent similar directories with different contents being missed

Author: aljcalandra

dev/tests/unit/Magento/FunctionalTestFramework/Util/ModuleResolverTest.php

@@ -62,6 +62,8 @@ public function testGetModulePathsAggregate()
         $this->setMockResolverProperties($resolver, null, [0 => "Magento_example"]);
         $this->assertEquals(
             [
+                "example" . DIRECTORY_SEPARATOR . "paths",
+                "example" . DIRECTORY_SEPARATOR . "paths",
                 "example" . DIRECTORY_SEPARATOR . "paths"
             ],
             $resolver->getModulesPath()
@@ -86,6 +88,8 @@ public function testGetModulePathsLocations()
         $this->setMockResolverProperties($resolver, null, null);
         $this->assertEquals(
             [
+                "example" . DIRECTORY_SEPARATOR . "paths",
+                "example" . DIRECTORY_SEPARATOR . "paths",
                 "example" . DIRECTORY_SEPARATOR . "paths"
             ],
             $resolver->getModulesPath()
@@ -150,7 +154,7 @@ function ($arg1, $arg2) {
         );
         $resolver = ModuleResolver::getInstance();
         $this->setMockResolverProperties($resolver, null, null, ["somePath"]);
-        $this->assertEquals(["lastPath"], $resolver->getModulesPath());
+        $this->assertEquals(["lastPath", "lastPath"], $resolver->getModulesPath());
         TestLoggingUtil::getInstance()->validateMockLogStatement(
             'info',
             'excluding module',

src/Magento/FunctionalTestingFramework/Util/ModuleResolver.php

@@ -235,7 +235,7 @@ private function aggregateTestModulePaths()
         ];
 
         foreach ($codePathsToPattern as $codePath => $pattern) {
-            $allModulePaths = array_merge($allModulePaths, $this->globRelevantPaths($codePath, $pattern));
+            $allModulePaths = array_merge_recursive($allModulePaths, $this->globRelevantPaths($codePath, $pattern));
         }
 
         return $allModulePaths;
@@ -289,7 +289,7 @@ private static function globRelevantWrapper($testPath, $pattern)
         $subDirectory = "*" . DIRECTORY_SEPARATOR;
         $directories = glob($testPath . $subDirectory . $pattern, GLOB_ONLYDIR);
         foreach (glob($testPath . $subDirectory, GLOB_ONLYDIR) as $dir) {
-            $directories = array_merge($directories, self::globRelevantWrapper($dir, $pattern));
+            $directories = array_merge_recursive($directories, self::globRelevantWrapper($dir, $pattern));
         }
         return $directories;
     }