MQE-1117: dontSeeJsError does not catch JS errors (#242)

aljcalandra · web-flow · commit 68c8d68a7247 · 2018-10-03T09:24:25.000-05:00
- Added check for null driver to prevent php fatal error
diff --git a/src/Magento/FunctionalTestingFramework/Extension/BaseExtension.php b/src/Magento/FunctionalTestingFramework/Extension/BaseExtension.php
@@ -90,6 +90,9 @@ public function getUri()
     protected function pageChanged()
     {
         try {
+            if ($this->getDriver() === null) {
+                return false;
+            }
             $currentUri = $this->getDriver()->_getCurrentUri();
 
             if ($this->uri !== $currentUri) {

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,9 @@ public function getUri()`
`90`	`90`	`protected function pageChanged()`
`91`	`91`	`{`
`92`	`92`	`try {`
	`93`	`+ if ($this->getDriver() === null) {`
	`94`	`+ return false;`
	`95`	`+ }`
`93`	`96`	`$currentUri = $this->getDriver()->_getCurrentUri();`
`94`	`97`
`95`	`98`	`if ($this->uri !== $currentUri) {`