Skip to content

Commit 829a825

Browse files
committed
add check for isBuiltin method
1 parent 00b0e54 commit 829a825

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/Magento/FunctionalTestingFramework/Code/Reader/ClassReader.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ class ClassReader implements ClassReaderInterface
1313
* @param string $className
1414
* @return array|null
1515
* @throws \ReflectionException
16+
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
1617
*/
1718
public function getConstructor($className)
1819
{
@@ -24,8 +25,9 @@ public function getConstructor($className)
2425
/** @var $parameter \ReflectionParameter */
2526
foreach ($constructor->getParameters() as $parameter) {
2627
try {
27-
$name = $parameter->getType() && !$parameter->getType()->isBuiltin()
28-
? new \ReflectionClass($parameter->getType()->getName())
28+
$paramType = $parameter->getType();
29+
$name = ($paramType && method_exists($paramType, 'isBuiltin') && !$paramType->isBuiltin())
30+
? new \ReflectionClass($paramType->getName())
2931
: null;
3032
$result[] = [
3133
$parameter->getName(),

src/Magento/FunctionalTestingFramework/System/Code/ClassReader.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ class ClassReader
2020
* @param string $method
2121
* @return array|null
2222
* @throws \ReflectionException
23+
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
2324
*/
2425
public function getParameters($className, $method)
2526
{
@@ -31,8 +32,9 @@ public function getParameters($className, $method)
3132
/** @var $parameter \ReflectionParameter */
3233
foreach ($method->getParameters() as $parameter) {
3334
try {
34-
$name = $parameter->getType() && !$parameter->getType()->isBuiltin()
35-
? new \ReflectionClass($parameter->getType()->getName())
35+
$paramType = $parameter->getType();
36+
$name = ($paramType && method_exists($paramType, 'isBuiltin') && !$paramType->isBuiltin())
37+
? new \ReflectionClass($paramType->getName())
3638
: null;
3739
$result[$parameter->getName()] = [
3840
$parameter->getName(),

0 commit comments

Comments
 (0)