Skip to content

Commit d7ea51d

Browse files
committed
#337: adjust type annotations, ensoure integer return type in all instances
1 parent d4581b4 commit d7ea51d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/Magento/FunctionalTestingFramework/Console/RunTestCommand.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ protected function configure()
4646
*
4747
* @param InputInterface $input
4848
* @param OutputInterface $output
49-
* @return int
49+
* @return integer
5050
* @throws \Exception
5151
*
5252
* @SuppressWarnings(PHPMD.UnusedLocalVariable)

src/Magento/FunctionalTestingFramework/Console/RunTestFailedCommand.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ protected function configure()
5959
*
6060
* @param InputInterface $input
6161
* @param OutputInterface $output
62-
* @return int
62+
* @return integer
6363
* @throws \Exception
6464
*
6565
* @SuppressWarnings(PHPMD.UnusedLocalVariable)
@@ -78,7 +78,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
7878
$testConfiguration = $this->getFailedTestList();
7979

8080
if ($testConfiguration === null) {
81-
return null;
81+
// no failed tests found, run is a success
82+
return 0;
8283
}
8384

8485
$command = $this->getApplication()->find('generate:tests');

src/Magento/FunctionalTestingFramework/Console/RunTestGroupCommand.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ protected function configure()
5353
*
5454
* @param InputInterface $input
5555
* @param OutputInterface $output
56-
* @return int
56+
* @return integer
5757
* @throws \Exception
5858
*
5959
* @SuppressWarnings(PHPMD.UnusedLocalVariable)

0 commit comments

Comments
 (0)