MC-5474: Anchor tag name is used on banner/slide/image wrapper when no link is specified by admin

Move button-item a/div conditional switch to master template

Author: danmooney2

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/button-item/default/master.html

@@ -6,7 +6,10 @@
 -->
 
 <div attr="data.main.attributes" ko-style="data.main.style" css="data.main.css">
-    <a attr="data.link.attributes" ko-style="data.link.style" css="data.link.css">
+    <a if="data.link.attributes().href" attr="data.link.attributes" ko-style="data.link.style" css="data.link.css">
         <span attr="data.link_text.attributes" html="data.link_text.html"></span>
     </a>
+    <div ifnot="data.link.attributes().href" attr="data.link.attributes" ko-style="data.link.style" css="data.link.css">
+        <span attr="data.link_text.attributes" html="data.link_text.html"></span>
+    </div>
 </div>

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/button-item/default/preview.html

@@ -10,8 +10,7 @@
      css="Object.assign({focused: $parent.parent.preview.focusedButton() === $index()}, data.main.css())"
      class="pagebuilder-content-type pagebuilder-button-item no-system-border focus-options">
     <render args="getOptions().template" />
-    <a if="data.link.attributes().href"
-       attr="data.link.attributes"
+    <a attr="data.link.attributes"
        ko-style="data.link.style"
        css="data.link.css"
        click="function (context, event) { onClick($index(), event); }"
@@ -22,16 +21,4 @@
               event="{ focusin: function (context, event) { onFocusIn($index(), event); }, focusout: function (context, event) { onFocusOut($index(), event); } }">
         </span>
     </a>
-    <div ifnot="data.link.attributes().href"
-         attr="data.link.attributes"
-         ko-style="data.link.style"
-         css="data.link.css"
-         click="function (context, event) { onClick($index(), event); }"
-         event="{ dragstart: function(context, event) { event.preventDefault(); }}">
-             <span class="button-item-drag-handle" css="{disabled: parent.parent.children().length <= 1}"></span>
-             <span attr="data.link_text.attributes"
-                  data-bind="liveEdit: { field: 'button_text', placeholder: buttonPlaceholder, selectAll: true }, hasFocusNoScroll: $parent.parent.preview.focusedButton() === $index()"
-                  event="{ focusin: function (context, event) { onFocusIn($index(), event); }, focusout: function (context, event) { onFocusOut($index(), event); } }">
-             </span>
-    </div>
 </div>

app/code/Magento/PageBuilder/view/frontend/web/css/source/content-type/button-item/_default.less

@@ -13,11 +13,14 @@
         max-width: 100%;
         word-wrap: break-word;
     }
+    div[data-element='link'] {
+        cursor: default;
+    }
 }
 
 a,
-button {
-
+button,
+div {
     &.pagebuilder-button-link {
         .lib-button-l();
         .lib-button-as-link(
@@ -45,6 +48,4 @@ button {
         .lib-css(border-radius, @button__border-radius);
         box-shadow: none;
     }
-
-
 }