Skip to content

Commit 019b611

Browse files
author
oleksandrkravchuk
committed
Merge branch 'community-features-252' of github.com:swnsma/magento2-1 into community-features-252
2 parents 0b92de9 + 4b5eb90 commit 019b611

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

app/code/Magento/Review/view/adminhtml/templates/rating/stars/summary.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
?>
1212
<?php if ($block->getRatingSummary()->getCount()): ?>
1313
<div class="rating-box">
14-
<div class="rating"/>
14+
<div class="rating"></div>
1515
</div>
1616
<?= /* @noEscape */ $secureRenderer->renderStyleAsTag(
1717
"width:" . /* @noEscape */ ceil($block->getRatingSummary()->getSum() /

app/code/Magento/Sales/view/adminhtml/templates/order/create/sidebar/items.phtml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,11 @@
66

77
/* @var $block \Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\AbstractSidebar */
88
/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */
9+
10+
$blockDataId = $block->getDataId();
11+
$jsEscapedBlockDataId = $block->escapeJs($blockDataId);
912
?>
10-
<div class="create-order-sidebar-block" id="sidebar_data_<?= $block->escapeHtmlAttr($block->getDataId()) ?>">
13+
<div class="create-order-sidebar-block" id="sidebar_data_<?= $block->escapeHtmlAttr($blockDataId) ?>">
1114
<div class="head sidebar-title-block">
1215
<a href="#" class="action-refresh" title="<?= $block->escapeHtml(__('Refresh')) ?>">
1316
<span><?= $block->escapeHtml(__('Refresh')) ?></span>
@@ -19,9 +22,12 @@
1922
</div>
2023
<?= /* @noEscape */ $secureRenderer->renderEventListenerAsTag(
2124
'onclick',
22-
"order.loadArea('sidebar_" . $block->escapeJs($block->getDataId()) .
23-
"', 'sidebar_data_" . $block->escapeJs($block->getDataId()) . "');event.preventDefault();",
24-
'div.head.sidebar-title-block'
25+
"order.loadArea(
26+
'sidebar_" . $jsEscapedBlockDataId ."',
27+
'sidebar_data_" . $jsEscapedBlockDataId . "'
28+
);
29+
event.preventDefault();",
30+
'div#sidebar_data_'. $jsEscapedBlockDataId . ' a.action-refresh'
2531
) ?>
2632
<div class="content">
2733
<div class="auto-scroll">
@@ -83,7 +89,7 @@
8389
type="checkbox"
8490
class="admin__control-checkbox"
8591
name="sidebar[remove][<?= (int) $block->getItemId($_item) ?>]"
86-
value="<?= $block->escapeHtmlAttr($block->getDataId()) ?>"
92+
value="<?= $block->escapeHtmlAttr($blockDataId) ?>"
8793
title="<?= $block->escapeHtml(__('Remove')) ?>" />
8894
<label class="admin__field-label"
8995
for="sidebar-remove-<?=
@@ -97,7 +103,7 @@
97103
<td class="col-add">
98104
<div class="admin__field-option">
99105
<?php if ($block->isConfigurationRequired($_item->getTypeId()) &&
100-
$block->getDataId() == 'wishlist'): ?>
106+
$blockDataId == 'wishlist'): ?>
101107
<a href="#"
102108
class="icon icon-configure"
103109
title="<?= $block->escapeHtml(__('Configure and Add to Order')) ?>">

app/code/Magento/Sales/view/adminhtml/templates/order/invoice/create/items.phtml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,11 @@
7676
<span><?= $block->escapeHtml(__('Invoice Comments')) ?></span>
7777
</label>
7878
<div class="admin__field-control">
79-
<textarea id="invoice_comment_text" name="invoice[comment_text]" class="admin__control-textarea"
80-
rows="3" cols="5"><?= $block->escapeHtml($block->getInvoice()->getCommentText()) ?>
81-
</textarea>
79+
<textarea id="invoice_comment_text"
80+
name="invoice[comment_text]"
81+
class="admin__control-textarea"
82+
rows="3"
83+
cols="5"><?= $block->escapeHtml($block->getInvoice()->getCommentText())?></textarea>
8284
</div>
8385
</div>
8486
</div>

0 commit comments

Comments
 (0)