Skip to content

Commit 061977e

Browse files
author
Oleksii Korshenko
authored
Merge pull request #802 from magento-engcom/develop-prs
[EngCom] Public Pull Requests: #8393 #8395 #8383 #8353 #8246
2 parents 1e9377a + 5582d1d commit 061977e

File tree

9 files changed

+47
-21
lines changed

9 files changed

+47
-21
lines changed

app/code/Magento/Braintree/Gateway/Response/VaultDetailsHandler.php

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,24 +41,33 @@ class VaultDetailsHandler implements HandlerInterface
4141
*/
4242
protected $config;
4343

44+
/**
45+
* @var \Magento\Framework\Serialize\SerializerInterface
46+
*/
47+
private $serializer;
48+
4449
/**
4550
* Constructor
4651
*
4752
* @param PaymentTokenInterfaceFactory $paymentTokenFactory
4853
* @param OrderPaymentExtensionInterfaceFactory $paymentExtensionFactory
4954
* @param Config $config
5055
* @param SubjectReader $subjectReader
56+
* @param \Magento\Framework\Serialize\SerializerInterface $serializer
5157
*/
5258
public function __construct(
5359
PaymentTokenInterfaceFactory $paymentTokenFactory,
5460
OrderPaymentExtensionInterfaceFactory $paymentExtensionFactory,
5561
Config $config,
56-
SubjectReader $subjectReader
62+
SubjectReader $subjectReader,
63+
\Magento\Framework\Serialize\SerializerInterface $serializer = null
5764
) {
5865
$this->paymentTokenFactory = $paymentTokenFactory;
5966
$this->paymentExtensionFactory = $paymentExtensionFactory;
6067
$this->config = $config;
6168
$this->subjectReader = $subjectReader;
69+
$this->serializer = $serializer ?: \Magento\Framework\App\ObjectManager::getInstance()
70+
->get(\Magento\Framework\Serialize\SerializerInterface::class);
6271
}
6372

6473
/**
@@ -133,7 +142,7 @@ private function getExpirationDate(Transaction $transaction)
133142
*/
134143
private function convertDetailsToJSON($details)
135144
{
136-
$json = \Zend_Json::encode($details);
145+
$json = $this->serializer->serialize($details);
137146
return $json ? $json : '{}';
138147
}
139148

app/code/Magento/Braintree/Test/Unit/Gateway/Response/VaultDetailsHandlerTest.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,20 @@ protected function setUp()
122122
->method('getCctypesMapper')
123123
->willReturn($mapperArray);
124124

125+
$this->serializer = $this->getMock(
126+
\Magento\Framework\Serialize\SerializerInterface::class,
127+
[],
128+
[],
129+
'',
130+
false
131+
);
132+
125133
$this->paymentHandler = new VaultDetailsHandler(
126134
$this->paymentTokenFactory,
127135
$this->paymentExtensionFactory,
128136
$this->config,
129-
$this->subjectReader
137+
$this->subjectReader,
138+
$this->serializer
130139
);
131140
}
132141

app/code/Magento/Bundle/view/adminhtml/layout/adminhtml_order_shipment_view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
99
<body>
1010
<referenceBlock name="shipment_items">
11-
<block class="Magento\Bundle\Block\Adminhtml\Sales\Order\Items\Renderer" as="bundle" template="sales/shipment/view/items/renderer.phtml"/>
11+
<block class="Magento\Bundle\Block\Adminhtml\Sales\Order\Items\Renderer" name="shipment_item_bundle" as="shipment_item_bundle" template="sales/shipment/view/items/renderer.phtml"/>
1212
</referenceBlock>
1313
</body>
1414
</page>

app/code/Magento/Customer/etc/frontend/sections.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
<action name="customer/account/logout"/>
1111
<action name="customer/account/loginPost"/>
1212
<action name="customer/account/createPost"/>
13+
<action name="customer/account/editPost"/>
1314
<action name="customer/ajax/login">
1415
<section name="checkout-data"/>
1516
<section name="cart"/>

app/code/Magento/Shipping/view/adminhtml/layout/adminhtml_order_shipment_new.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<block class="Magento\Sales\Block\Adminhtml\Order\View\Info" name="order_info" template="Magento_Sales::order/view/info.phtml"/>
1515
<block class="Magento\Sales\Block\Adminhtml\Order\Payment" name="order_payment"/>
1616
<block class="Magento\Shipping\Block\Adminhtml\Create\Items" name="order_items" template="create/items.phtml">
17-
<block class="Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer" as="default" template="Magento_Shipping::create/items/renderer/default.phtml"/>
17+
<block class="Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer" name="shipment_item_default" as="shipment_item_default" template="Magento_Shipping::create/items/renderer/default.phtml"/>
1818
<block class="Magento\Sales\Block\Adminhtml\Items\Column\Qty" name="column_qty" template="Magento_Sales::items/column/qty.phtml" group="column"/>
1919
<block class="Magento\Sales\Block\Adminhtml\Items\Column\Name" name="column_name" template="Magento_Sales::items/column/name.phtml" group="column"/>
2020
<block class="Magento\Framework\View\Element\Text\ListText" name="order_item_extra_info"/>

app/code/Magento/Shipping/view/adminhtml/layout/adminhtml_order_shipment_view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<block class="Magento\Sales\Block\Adminhtml\Order\View\Info" name="order_info" template="Magento_Sales::order/view/info.phtml"/>
1515
<block class="Magento\Sales\Block\Adminhtml\Order\Payment" name="order_payment"/>
1616
<block class="Magento\Shipping\Block\Adminhtml\View\Items" name="shipment_items" template="view/items.phtml">
17-
<block class="Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer" as="default" template="Magento_Shipping::view/items/renderer/default.phtml"/>
17+
<block class="Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer" name="shipment_item_default" as="shipment_item_default" template="Magento_Shipping::view/items/renderer/default.phtml"/>
1818
<block class="Magento\Sales\Block\Adminhtml\Items\Column\Qty" name="column_qty" template="Magento_Sales::items/column/qty.phtml" group="column"/>
1919
<block class="Magento\Sales\Block\Adminhtml\Items\Column\Name" name="column_name" template="Magento_Sales::items/column/name.phtml" group="column"/>
2020
<block class="Magento\Framework\View\Element\Text\ListText" name="order_item_extra_info"/>

app/code/Magento/Ui/view/base/web/js/form/form.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,11 @@ define([
5454
}
5555
break;
5656

57+
case 'select-multiple':
58+
var name = item.name.substring(0,(item.name.length - 2)); //remove [] from the name ending
59+
result[name] = _.pluck(item.selectedOptions, 'value');
60+
break;
61+
5762
default:
5863
result[item.name] = item.value;
5964
}

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"colinmollenhour/cache-backend-redis": "1.9",
3838
"colinmollenhour/cache-backend-file": "1.4",
3939
"composer/composer": "1.0.0-beta1",
40-
"monolog/monolog": "1.16.0",
40+
"monolog/monolog": "^1.17",
4141
"oyejorge/less.php": "~1.7.0",
4242
"pelago/emogrifier": "0.1.1",
4343
"tubalmartin/cssmin": "2.4.8-p4",

composer.lock

Lines changed: 16 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)