ENGCOM-8016: Refactor Category Link: Replace deprecated interface, clean the code #29564

Author: sidolov

app/code/Magento/Catalog/Model/CategoryLink.php

@@ -3,39 +3,41 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Catalog\Model;
 
+use Magento\Catalog\Api\Data\CategoryLinkExtensionInterface;
+use Magento\Catalog\Api\Data\CategoryLinkInterface;
+use Magento\Framework\Model\AbstractExtensibleModel;
+
 /**
  * @codeCoverageIgnore
  */
-class CategoryLink extends \Magento\Framework\Api\AbstractExtensibleObject implements
-    \Magento\Catalog\Api\Data\CategoryLinkInterface
+class CategoryLink extends AbstractExtensibleModel implements CategoryLinkInterface
 {
-    /**#@+
-     * Constants
-     */
-    const KEY_POSITION = 'position';
-    const KEY_CATEGORY_ID = 'category_id';
-    /**#@-*/
+    public const KEY_POSITION = 'position';
+    public const KEY_CATEGORY_ID = 'category_id';
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getPosition()
     {
-        return $this->_get(self::KEY_POSITION);
+        return $this->getData(self::KEY_POSITION);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getCategoryId()
     {
-        return $this->_get(self::KEY_CATEGORY_ID);
+        return $this->getData(self::KEY_CATEGORY_ID);
     }
 
     /**
+     * @inheritDoc
+     *
      * @param int $position
      * @return $this
      */
@@ -56,7 +58,7 @@ public function setCategoryId($categoryId)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @return \Magento\Catalog\Api\Data\CategoryLinkExtensionInterface|null
      */
@@ -66,14 +68,13 @@ public function getExtensionAttributes()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      *
      * @param \Magento\Catalog\Api\Data\CategoryLinkExtensionInterface $extensionAttributes
      * @return $this
      */
-    public function setExtensionAttributes(
-        \Magento\Catalog\Api\Data\CategoryLinkExtensionInterface $extensionAttributes
-    ) {
+    public function setExtensionAttributes(CategoryLinkExtensionInterface $extensionAttributes)
+    {
         return $this->_setExtensionAttributes($extensionAttributes);
     }
 }