Fixed issue when using dynamic elements

saphaljha · saphaljha · commit 0fee9a1ab949 · 2020-11-20T15:17:06.000+05:30
diff --git a/lib/internal/Magento/Framework/View/Helper/SecureHtmlRenderer.php b/lib/internal/Magento/Framework/View/Helper/SecureHtmlRenderer.php
@@ -116,6 +116,7 @@ function {$listenerFunction} () {
                 {$elementName}Array.forEach(function(element){
                     if (element) {
                         element.{$eventName} = function (event) {
+                            event.preventDefault();
                             var targetElement = element;
                             if (event && event.target) {
                                 targetElement = event.target;
@@ -124,10 +125,8 @@ function {$listenerFunction} () {
                         }
                     }
                 });
-            }
-            
-script;
-
+            }     
+        script;
         return $this->renderTag('script', ['type' => 'text/javascript'], $script, false);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ function {$listenerFunction} () {`
`116`	`116`	`{$elementName}Array.forEach(function(element){`
`117`	`117`	`if (element) {`
`118`	`118`	`element.{$eventName} = function (event) {`
	`119`	`+ event.preventDefault();`
`119`	`120`	`var targetElement = element;`
`120`	`121`	`if (event && event.target) {`
`121`	`122`	`targetElement = event.target;`
`@@ -124,10 +125,8 @@ function {$listenerFunction} () {`
`124`	`125`	`}`
`125`	`126`	`}`
`126`	`127`	`});`
`127`		`- }`
`128`		`-`
`129`		`-script;`
`130`		`-`
	`128`	`+ }`
	`129`	`+ script;`
`131`	`130`	`return $this->renderTag('script', ['type' => 'text/javascript'], $script, false);`
`132`	`131`	`}`
`133`	`132`