Skip to content

Commit 34bff12

Browse files
committed
Satic test fixes
1 parent 3bc8239 commit 34bff12

File tree

4 files changed

+17
-18
lines changed

4 files changed

+17
-18
lines changed

app/code/Magento/MediaContentCatalog/Observer/CategoryDelete.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
use Magento\MediaContentApi\Api\ExtractAssetsFromContentInterface;
1818

1919
/**
20-
* Observe the catalog_category_delete event and deletes relation between category content and media asset.
20+
* Observe the catalog_category_delete_after event and deletes relation between category content and media asset.
2121
*/
2222
class CategoryDelete implements ObserverInterface
2323
{
@@ -88,16 +88,16 @@ public function __construct(
8888
*/
8989
public function execute(Observer $observer): void
9090
{
91-
$model = $observer->getEvent()->getData('category');
91+
$category = $observer->getEvent()->getData('category');
9292
$contentAssetLinks = [];
9393

94-
if ($model instanceof CatalogCategory) {
94+
if ($category instanceof CatalogCategory) {
9595
foreach ($this->fields as $field) {
9696
$contentIdentity = $this->contentIdentityFactory->create(
9797
[
9898
self::TYPE => self::CONTENT_TYPE,
9999
self::FIELD => $field,
100-
self::ENTITY_ID => (string) $model->getEntityId(),
100+
self::ENTITY_ID => (string) $category->getEntityId(),
101101
]
102102
);
103103
$content = implode(PHP_EOL, $this->getContent->execute($contentIdentity));

app/code/Magento/MediaContentCatalog/Observer/ProductDelete.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,20 @@ public function __construct(
8888
*/
8989
public function execute(Observer $observer): void
9090
{
91-
$model = $observer->getEvent()->getData('product');
91+
$product = $observer->getEvent()->getData('product');
9292
$contentAssetLinks = [];
9393

94-
if ($model instanceof CatalogProduct) {
94+
if ($product instanceof CatalogProduct) {
9595
foreach ($this->fields as $field) {
9696
$contentIdentity = $this->contentIdentityFactory->create(
9797
[
9898
self::TYPE => self::CONTENT_TYPE,
9999
self::FIELD => $field,
100-
self::ENTITY_ID => (string) $model->getEntityId(),
100+
self::ENTITY_ID => (string) $product->getEntityId(),
101101
]
102102
);
103-
$content = implode(PHP_EOL, $this->getContent->execute($contentIdentity));
104-
$assets = $this->extractAssetsFromContent->execute($content);
103+
$productContent = implode(PHP_EOL, $this->getContent->execute($contentIdentity));
104+
$assets = $this->extractAssetsFromContent->execute($productContent);
105105

106106
foreach ($assets as $asset) {
107107
$contentAssetLinks[] = $this->contentAssetLinkFactory->create(

app/code/Magento/MediaContentCms/Observer/BlockDelete.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,19 @@ public function __construct(
8888
*/
8989
public function execute(Observer $observer): void
9090
{
91-
$model = $observer->getEvent()->getData('object');
91+
$block = $observer->getEvent()->getData('object');
9292
$contentAssetLinks = [];
9393

94-
if ($model instanceof CmsBlock) {
94+
if ($block instanceof CmsBlock) {
9595
foreach ($this->fields as $field) {
9696
$contentIdentity = $this->contentIdentityFactory->create(
9797
[
9898
self::TYPE => self::CONTENT_TYPE,
9999
self::FIELD => $field,
100-
self::ENTITY_ID => (string) $model->getId(),
100+
self::ENTITY_ID => (string) $block->getId(),
101101
]
102102
);
103-
104-
$assets = $this->extractAssetsFromContent->execute((string) $model->getData($field));
103+
$assets = $this->extractAssetsFromContent->execute((string) $block->getData($field));
105104

106105
foreach ($assets as $asset) {
107106
$contentAssetLinks[] = $this->contentAssetLinkFactory->create(

app/code/Magento/MediaContentCms/Observer/PageDelete.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,20 @@ public function __construct(
8888
*/
8989
public function execute(Observer $observer): void
9090
{
91-
$model = $observer->getEvent()->getData('object');
91+
$page = $observer->getEvent()->getData('object');
9292
$contentAssetLinks = [];
9393

94-
if ($model instanceof CmsPage) {
94+
if ($page instanceof CmsPage) {
9595
foreach ($this->fields as $field) {
9696
$contentIdentity = $this->contentIdentityFactory->create(
9797
[
9898
self::TYPE => self::CONTENT_TYPE,
9999
self::FIELD => $field,
100-
self::ENTITY_ID => (string) $model->getId(),
100+
self::ENTITY_ID => (string) $page->getId(),
101101
]
102102
);
103103

104-
$assets = $this->extractAssetsFromContent->execute((string) $model->getData($field));
104+
$assets = $this->extractAssetsFromContent->execute((string) $page->getData($field));
105105

106106
foreach ($assets as $asset) {
107107
$contentAssetLinks[] = $this->contentAssetLinkFactory->create(

0 commit comments

Comments
 (0)