MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number

- fixed review comments

Author: Prabhu Ram

app/code/Magento/SalesGraphQl/Model/SalesItem/ShippingTaxCalculator.php

@@ -3,15 +3,20 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\SalesGraphQl\Model\SalesItem;
 
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Model\EntityInterface;
 use Magento\Tax\Api\Data\OrderTaxDetailsItemInterface;
 use Magento\Tax\Api\OrderTaxManagementInterface;
-use \Magento\Quote\Model\Quote\Address;
+use Magento\Quote\Model\Quote\Address;
+use Magento\Framework\Exception\NoSuchEntityException;
 
+/**
+ * Calculates shipping taxes for sales items (Invoices, Credit memo)
+ */
 class ShippingTaxCalculator
 {
     /**
@@ -34,12 +39,12 @@ public function __construct(
      * @param OrderInterface $order
      * @param EntityInterface $salesItem
      * @return array
-     * @throws \Magento\Framework\Exception\NoSuchEntityException
+     * @throws NoSuchEntityException
      */
     public function calculateShippingTaxes(
         OrderInterface $order,
         EntityInterface $salesItem
-    ) {
+    ): array {
         $orderTaxDetails = $this->orderTaxManagement->getOrderTaxDetails($order->getId());
         $taxClassBreakdown = [];
         // Apply any taxes for shipping
@@ -64,7 +69,7 @@ public function calculateShippingTaxes(
     /**
      * Accumulates the pre-calculated taxes for each tax class
      *
-     * This method accepts and returns the 'taxClassAmount' array with format:
+     * This method accepts and returns the '$taxClassBreakdown' array with format:
      * array(
      *  $index => array(
      *      'tax_amount'        => $taxAmount,
@@ -74,13 +79,16 @@ public function calculateShippingTaxes(
      *  )
      * )
      *
-     * @param  array                        $taxClassBreakdown
+     * @param  array $taxClassBreakdown
      * @param  OrderTaxDetailsItemInterface $itemTaxDetail
-     * @param  float                        $taxRatio
+     * @param  float $taxRatio
      * @return array
      */
-    private function aggregateTaxes($taxClassBreakdown, OrderTaxDetailsItemInterface $itemTaxDetail, $taxRatio)
-    {
+    private function aggregateTaxes(
+        array $taxClassBreakdown,
+        OrderTaxDetailsItemInterface $itemTaxDetail,
+        float $taxRatio
+    ): array {
         $itemAppliedTaxes = $itemTaxDetail->getAppliedTaxes();
         foreach ($itemAppliedTaxes as $itemAppliedTax) {
             $taxAmount = $itemAppliedTax->getAmount() * $taxRatio;

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/InvoiceTest.php

@@ -794,7 +794,7 @@ private function placeOrder(string $cartId): string
      * @param string $orderNumber
      * @return array
      */
-    private function getCustomerInvoicesBasedOnOrderNumber($orderNumber = null): array
+    private function getCustomerInvoicesBasedOnOrderNumber($orderNumber): array
     {
         $query =
             <<<QUERY