Skip to content

Commit 363a100

Browse files
committed
Cover long folder names in media gallery with mftf test
1 parent 084f689 commit 363a100

File tree

3 files changed

+50
-1
lines changed

3 files changed

+50
-1
lines changed

app/code/Magento/MediaGalleryUi/Model/Directories/GetFolderTree.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
*/
1818
class GetFolderTree
1919
{
20+
private const NAME_LENGTH = 50;
21+
2022
/**
2123
* @var Filesystem
2224
*/
@@ -84,7 +86,9 @@ private function getDirectories(): array
8486
}
8587

8688
$pathArray = explode('/', $path);
87-
$displayName = strlen(end($pathArray)) > 50 ? substr(end($pathArray),0,50)."..." : end($pathArray);
89+
$displayName = strlen(end($pathArray)) > self::NAME_LENGTH ?
90+
substr(end($pathArray),0, self::NAME_LENGTH) . "..." :
91+
end($pathArray);
8892
$directories[] = [
8993
'data' => count($pathArray) > 0 ? $displayName : $path,
9094
'attr' => ['id' => $path],

app/code/Magento/MediaGalleryUi/Test/Mftf/Data/AdminMediaGalleryFolderData.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,7 @@
1313
</entity>
1414
<entity name="AdminMediaGalleryFolderInvalidData">
1515
<data key="name">,.?/:;'[{]}|~`!@#$%^*()_=+</data>
16+
<data key="longName">mediagallerylongfoldernamemediagallerylongfoldername54</data>
17+
<data key="cutedName">mediagallerylongfoldernamemediagallerylongfolderna...</data>
1618
</entity>
1719
</entities>
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="AdminMediaGalleryCreateFolderWithLongNamesTest">
11+
<annotations>
12+
<features value="MediaGallery"/>
13+
<useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1758"/>
14+
<stories value="Create new folder with long names in Media Gallery"/>
15+
<title value="Create new folder with long names in Media Gallery"/>
16+
<testCaseId value="https://studio.cucumber.io/projects/131313/test-plan/folders/1054245/scenarios/4456547"/>
17+
<description value="Creating, deleting new folder functionality in Media Gallery"/>
18+
<severity value="CRITICAL"/>
19+
<group value="media_gallery_ui"/>
20+
</annotations>
21+
<before>
22+
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
23+
<actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openMediaGallery"/>
24+
</before>
25+
26+
<actionGroup ref="AdminMediaGalleryOpenNewFolderFormActionGroup" stepKey="openNewFolderForm"/>
27+
<actionGroup ref="AdminMediaGalleryCreateNewFolderActionGroup" stepKey="createNewFolderWithNotValidName">
28+
<argument name="name" value="{{AdminMediaGalleryFolderInvalidData.longName}}"/>
29+
</actionGroup>
30+
<actionGroup ref="AdminMediaGalleryAssertFolderNameActionGroup" stepKey="AssertFolderName">
31+
<argument name="name" value="{{AdminMediaGalleryFolderInvalidData.cutedName}}"/>
32+
</actionGroup>
33+
<actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openMediaGallery"/>
34+
35+
36+
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectFolder">
37+
<argument name="name" value="{{AdminMediaGalleryFolderInvalidData.cutedName}}"/>
38+
</actionGroup>
39+
<actionGroup ref="AdminMediaGalleryFolderDeleteActionGroup" stepKey="deleteFolder">
40+
<argument name="name" value="{{AdminMediaGalleryFolderInvalidData.cutedName}}"/>
41+
</actionGroup>
42+
</test>
43+
</tests>

0 commit comments

Comments
 (0)