Skip to content

Commit 3c8f132

Browse files
committed
Specifically ask for the Json Serializer object and not just relying on the interface that could change
1 parent 53b0776 commit 3c8f132

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

app/code/Magento/Braintree/Gateway/Response/VaultDetailsHandler.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,32 +42,33 @@ class VaultDetailsHandler implements HandlerInterface
4242
protected $config;
4343

4444
/**
45-
* @var \Magento\Framework\Serialize\SerializerInterface
45+
* @var \Magento\Framework\Serialize\Serializer\Json
4646
*/
4747
private $serializer;
4848

4949
/**
50-
* Constructor
50+
* VaultDetailsHandler constructor.
5151
*
5252
* @param PaymentTokenInterfaceFactory $paymentTokenFactory
5353
* @param OrderPaymentExtensionInterfaceFactory $paymentExtensionFactory
5454
* @param Config $config
5555
* @param SubjectReader $subjectReader
56-
* @param \Magento\Framework\Serialize\SerializerInterface $serializer
56+
* @param \Magento\Framework\Serialize\Serializer\Json|null $serializer
57+
* @throws \RuntimeException
5758
*/
5859
public function __construct(
5960
PaymentTokenInterfaceFactory $paymentTokenFactory,
6061
OrderPaymentExtensionInterfaceFactory $paymentExtensionFactory,
6162
Config $config,
6263
SubjectReader $subjectReader,
63-
\Magento\Framework\Serialize\SerializerInterface $serializer = null
64+
\Magento\Framework\Serialize\Serializer\Json $serializer = null
6465
) {
6566
$this->paymentTokenFactory = $paymentTokenFactory;
6667
$this->paymentExtensionFactory = $paymentExtensionFactory;
6768
$this->config = $config;
6869
$this->subjectReader = $subjectReader;
6970
$this->serializer = $serializer ?: \Magento\Framework\App\ObjectManager::getInstance()
70-
->get(\Magento\Framework\Serialize\SerializerInterface::class);
71+
->get(\Magento\Framework\Serialize\Serializer\Json::class);
7172
}
7273

7374
/**

app/code/Magento/Braintree/Test/Unit/Gateway/Response/VaultDetailsHandlerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ protected function setUp()
123123
->willReturn($mapperArray);
124124

125125
$this->serializer = $this->getMock(
126-
\Magento\Framework\Serialize\SerializerInterface::class,
126+
\Magento\Framework\Serialize\Serializer\Json::class,
127127
[],
128128
[],
129129
'',

0 commit comments

Comments
 (0)