#29174 Add save_rewrites_history to categories via API

Author: amenk

app/code/Magento/CatalogUrlRewrite/Plugin/Webapi/Controller/Rest/InputParamsResolver.php

@@ -8,6 +8,7 @@
 
 namespace Magento\CatalogUrlRewrite\Plugin\Webapi\Controller\Rest;
 
+use Magento\Catalog\Api\CategoryRepositoryInterface;
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use Magento\Framework\Webapi\Rest\Request as RestRequest;
 
@@ -18,6 +19,8 @@
  */
 class InputParamsResolver
 {
+    const SAVE_REWRITES_HISTORY = 'save_rewrites_history';
+
     /**
      * @var RestRequest
      */
@@ -32,7 +35,7 @@ public function __construct(RestRequest $request)
     }
 
     /**
-     * Add 'save_rewrites_history' param to the product data
+     * Add 'save_rewrites_history' param to the product and category data
      *
      * @see \Magento\CatalogUrlRewrite\Plugin\Catalog\Controller\Adminhtml\Product\Initialization\Helper
      * @param \Magento\Webapi\Controller\Rest\InputParamsResolver $subject
@@ -47,12 +50,27 @@ public function afterResolve(\Magento\Webapi\Controller\Rest\InputParamsResolver
         $requestBodyParams = $this->request->getBodyParams();
 
         if ($this->isProductSaveCalled($serviceClassName, $serviceMethodName)
-            && $this->isCustomAttributesExists($requestBodyParams)) {
+            && $this->isCustomAttributesExists($requestBodyParams, 'product')) {
             foreach ($requestBodyParams['product']['custom_attributes'] as $attribute) {
-                if ($attribute['attribute_code'] === 'save_rewrites_history') {
+                if ($attribute['attribute_code'] === self::SAVE_REWRITES_HISTORY) {
                     foreach ($result as $resultItem) {
                         if ($resultItem instanceof \Magento\Catalog\Model\Product) {
-                            $resultItem->setData('save_rewrites_history', (bool)$attribute['value']);
+                            $resultItem->setData(self::SAVE_REWRITES_HISTORY, (bool)$attribute['value']);
+                            break 2;
+                        }
+                    }
+                    break;
+                }
+            }
+        }
+
+        if ($this->isCategorySaveCalled($serviceClassName, $serviceMethodName)
+            && $this->isCustomAttributesExists($requestBodyParams, 'category')) {
+            foreach ($requestBodyParams['category']['custom_attributes'] as $attribute) {
+                if ($attribute['attribute_code'] === self::SAVE_REWRITES_HISTORY) {
+                    foreach ($result as $resultItem) {
+                        if ($resultItem instanceof \Magento\Catalog\Model\Category) {
+                            $resultItem->setData(self::SAVE_REWRITES_HISTORY, (bool)$attribute['value']);
                             break 2;
                         }
                     }
@@ -75,14 +93,27 @@ private function isProductSaveCalled(string $serviceClassName, string $serviceMe
         return $serviceClassName === ProductRepositoryInterface::class && $serviceMethodName === 'save';
     }
 
+    /**
+     * Check that category save method called
+     *
+     * @param string $serviceClassName
+     * @param string $serviceMethodName
+     * @return bool
+     */
+    private function isCategorySaveCalled(string $serviceClassName, string $serviceMethodName): bool
+    {
+        return $serviceClassName === CategoryRepositoryInterface::class && $serviceMethodName === 'save';
+    }
+
     /**
      * Check is any custom options exists in product data
      *
      * @param array $requestBodyParams
+     * @param string $entityCode
      * @return bool
      */
-    private function isCustomAttributesExists(array $requestBodyParams): bool
+    private function isCustomAttributesExists(array $requestBodyParams, string $entityCode): bool
     {
-        return !empty($requestBodyParams['product']['custom_attributes']);
+        return !empty($requestBodyParams[$entityCode]['custom_attributes']);
     }
 }

app/code/Magento/CatalogUrlRewrite/Test/Unit/Plugin/Webapi/Controller/Rest/InputParamsResolverTest.php

@@ -8,7 +8,9 @@
 
 namespace Magento\CatalogUrlRewrite\Test\Unit\Plugin\Webapi\Controller\Rest;
 
+use Magento\Catalog\Api\CategoryRepositoryInterface;
 use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Catalog\Model\Category;
 use Magento\Catalog\Model\Product;
 use Magento\CatalogUrlRewrite\Plugin\Webapi\Controller\Rest\InputParamsResolver as InputParamsResolverPlugin;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
@@ -74,6 +76,10 @@ class InputParamsResolverTest extends TestCase
     protected function setUp(): void
     {
         $this->saveRewritesHistory = 'save_rewrites_history';
+    }
+
+    public function testAfterResolveWithProduct()
+    {
         $this->requestBodyParams = [
             'product' => [
                 'sku' => 'test',
@@ -99,10 +105,7 @@ protected function setUp(): void
                 'request' => $this->request
             ]
         );
-    }
 
-    public function testAfterResolve()
-    {
         $this->route->expects($this->once())
             ->method('getServiceClass')
             ->willReturn(ProductRepositoryInterface::class);
@@ -115,4 +118,47 @@ public function testAfterResolve()
 
         $this->plugin->afterResolve($this->subject, $this->result);
     }
+
+
+    public function testAfterResolveWithCategory()
+    {
+        $this->requestBodyParams = [
+            'category' => [
+                'name' => 'new name',
+                'custom_attributes' => [
+                    ['attribute_code' => $this->saveRewritesHistory, 'value' => 1],
+                    ['attribute_code' => 'url_key', 'value' => 'new name']
+                ]
+            ]
+        ];
+
+        $this->route = $this->createPartialMock(Route::class, ['getServiceMethod', 'getServiceClass']);
+        $this->request = $this->createPartialMock(RestRequest::class, ['getBodyParams']);
+        $this->request->expects($this->any())->method('getBodyParams')->willReturn($this->requestBodyParams);
+        $this->subject = $this->createPartialMock(InputParamsResolver::class, ['getRoute']);
+        $this->subject->expects($this->any())->method('getRoute')->willReturn($this->route);
+        $this->category = $this->createPartialMock(Category::class, ['setData']);
+
+        $this->result = [false, $this->category, 'test'];
+
+        $this->objectManager = new ObjectManager($this);
+        $this->plugin = $this->objectManager->getObject(
+            InputParamsResolverPlugin::class,
+            [
+                'request' => $this->request
+            ]
+        );
+
+        $this->route->expects($this->once())
+            ->method('getServiceClass')
+            ->willReturn(CategoryRepositoryInterface::class);
+        $this->route->expects($this->once())
+            ->method('getServiceMethod')
+            ->willReturn('save');
+        $this->category->expects($this->once())
+            ->method('setData')
+            ->with($this->saveRewritesHistory, true);
+
+        $this->plugin->afterResolve($this->subject, $this->result);
+    }
 }