Skip to content

Commit 57db694

Browse files
Code review changes
1 parent e31dafd commit 57db694

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

app/code/Magento/MediaGallery/Test/Unit/Model/DataExtractorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public function testExtractData(string $class, $interfaceClass, array $expectedD
6767
* @param array $data
6868
* @param object $model
6969
*/
70-
protected function checkAssetValues(array $expectedData, array $data, $model)
70+
private function checkAssetValues(array $expectedData, array $data, $model)
7171
{
7272
foreach ($expectedData as $expectedDataKey => $expectedDataItem) {
7373
$this->assertEquals($data[$expectedDataKey] ?? null, $model->{$expectedDataItem['method']}());
@@ -81,7 +81,7 @@ protected function checkAssetValues(array $expectedData, array $data, $model)
8181
* @param array $data
8282
* @param object $model
8383
*/
84-
protected function checkKeyWordValues(array $expectedData, array $data, $model)
84+
private function checkKeyWordValues(array $expectedData, array $data, $model)
8585
{
8686
foreach ($expectedData as $expectedDataKey => $expectedDataItem) {
8787
$this->assertEquals($data[$expectedDataKey] ?? null, $model->{$expectedDataItem['method']}());

app/code/Magento/MediaGallery/etc/db_schema.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<column xsi:type="varchar" name="content_type" length="255" nullable="true" comment="Content Type"/>
1515
<column xsi:type="int" name="width" padding="10" unsigned="true" nullable="false" identity="false" default="0" comment="Width"/>
1616
<column xsi:type="int" name="height" padding="10" unsigned="true" nullable="false" identity="false" default="0" comment="Height"/>
17-
<column xsi:type="int" name="size" padding="10" unsigned="true" nullable="false" identity="false" default="0" comment="Size"/>
17+
<column xsi:type="int" name="size" padding="10" unsigned="true" nullable="false" identity="false" comment="Asset file size in bytes"/>
1818
<column xsi:type="timestamp" name="created_at" on_update="false" nullable="false" default="CURRENT_TIMESTAMP" comment="Created At"/>
1919
<column xsi:type="timestamp" name="updated_at" on_update="true" nullable="false" default="CURRENT_TIMESTAMP" comment="Updated At"/>
2020
<constraint xsi:type="primary" referenceId="PRIMARY">

app/code/Magento/MediaGalleryApi/Api/Data/AssetInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public function getHeight(): int;
6666
public function getWidth(): int;
6767

6868
/**
69-
* Retrieve full licensed asset's size
69+
* Retrieve asset file size in bytes
7070
*
7171
* @return int
7272
*/

0 commit comments

Comments
 (0)