Skip to content

Commit 5f1d43a

Browse files
committed
#1703: The deleted tags are not removed from Tags drop-down until the web page is refreshed - added requested changes
1 parent bf77de0 commit 5f1d43a

4 files changed

+9
-9
lines changed

app/code/Magento/MediaGalleryUi/Test/Mftf/ActionGroup/AdminMediaGalleryEditAssetRemoveKeywordActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
<description>Remove Keywords on the Edit Details panel</description>
1414
</annotations>
1515
<arguments>
16-
<argument name="selectedKeywords"/>
16+
<argument name="keyword" type="string"/>
1717
</arguments>
1818

19-
<click selector="{{AdminEnhancedMediaGalleryEditDetailsSection.removeSelectedKeyword(selectedKeywords)}}" stepKey="removeKeyword"/>
19+
<click selector="{{AdminEnhancedMediaGalleryEditDetailsSection.removeSelectedKeyword(keyword)}}" stepKey="removeKeyword"/>
2020
</actionGroup>
2121
</actionGroups>
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@
88

99
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11-
<actionGroup name="AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup">
11+
<actionGroup name="AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup">
1212
<annotations>
13-
<description>Verifies removed image keywords on the View Details panel</description>
13+
<description>Verifies that the passed comma-separated list of keywords are not present on the View Details panel</description>
1414
</annotations>
1515
<arguments>
16-
<argument name="keywords"/>
16+
<argument name="keywords" type="string"/>
1717
</arguments>
1818

1919
<grabTextFrom selector="{{AdminEnhancedMediaGalleryViewDetailsSection.keywords}}" stepKey="grabKeywords"/>

app/code/Magento/MediaGalleryUi/Test/Mftf/Section/AdminEnhancedMediaGalleryEditDetailsSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<element name="description" type="textarea" selector="#description"/>
1515
<element name="newKeyword" type="input" selector="[data-ui-id='keyword']"/>
1616
<element name="addNewKeyword" type="input" selector="[data-ui-id='add-keyword']"/>
17-
<element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{selectedKeywords}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>
17+
<element name="removeSelectedKeyword" type="button" selector="//span[contains(text(), '{{keyword}}')]/following-sibling::button[@data-action='remove-selected-item']" parameterized="true"/>
1818
<element name="cancel" type="button" selector="#image-details-action-cancel"/>
1919
<element name="save" type="button" selector="#image-details-action-save"/>
2020
</section>

app/code/Magento/MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyUpdatedTagsTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@
4040
</actionGroup>
4141
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsEditActionGroup" stepKey="updateImageDetails"/>
4242
<actionGroup ref="AdminMediaGalleryEditAssetRemoveKeywordActionGroup" stepKey="removeKeywords">
43-
<argument name="selectedKeywords" value="UpdatedImageDetails.keyword"/>
43+
<argument name="keyword" value="{{UpdatedImageDetails.keyword}}"/>
4444
</actionGroup>
4545
<actionGroup ref="AdminEnhancedMediaGalleryImageDetailsSaveActionGroup" stepKey="saveUpdatedImage">
4646
<argument name="image" value="UpdatedImageDetails"/>
4747
</actionGroup>
48-
<actionGroup ref="AdminEnhancedMediaGalleryVerifyRemovedImageKeywordsActionGroup" stepKey="verifyRemovedKeywords">
49-
<argument name="keywords" value="UpdatedImageDetails.keyword"/>
48+
<actionGroup ref="AssetAdminEnhancedMediaGalleryAssetDetailsKeywordsAbsentActionGroup" stepKey="verifyRemovedKeywords">
49+
<argument name="keywords" value="{{UpdatedImageDetails.keyword}}"/>
5050
</actionGroup>
5151
</test>
5252
</tests>

0 commit comments

Comments
 (0)