Skip to content

Commit 6295f3d

Browse files
nuzilihor-sviziev
andauthored
Apply suggestions from code review - Fix tests
Co-authored-by: Ihor Sviziev <[email protected]>
1 parent 3f4ae32 commit 6295f3d

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

app/code/Magento/Catalog/Test/Unit/Model/Product/Webapi/Rest/RequestTypeBasedDeserializerTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class RequestTypeBasedDeserializerTest extends \PHPUnit\Framework\TestCase
3232
*/
3333
private $requestMock;
3434

35-
public function setUp()
35+
public function setUp(): void
3636
{
3737
/** @var DeserializerFactory|MockObject $deserializeFactoryMock */
3838
$this->deserializeFactoryMock = $this->createMock(DeserializerFactory::class);
@@ -57,11 +57,11 @@ public function setUp()
5757
* @throws \Magento\Framework\Webapi\Exception
5858
*/
5959
public function testDeserialize(
60-
$body,
61-
$contentType,
60+
string $body,
61+
string $contentType,
6262
DeserializerInterface $deserializer,
6363
array $expectedResult
64-
) {
64+
): void {
6565
$this->requestMock->method('getContentType')
6666
->willReturn($contentType);
6767
$this->deserializeFactoryMock->expects($this->any())
@@ -71,7 +71,7 @@ public function testDeserialize(
7171
$this->assertEquals($expectedResult, $this->requestTypeBasedDeserializer->deserialize($body));
7272
}
7373

74-
public function getDeserializerDataProvider()
74+
public function getDeserializerDataProvider(): array
7575
{
7676
return [
7777
'request body with xml data' => [
@@ -126,7 +126,7 @@ public function getDeserializerDataProvider()
126126
*
127127
* @return DeserializerJson
128128
*/
129-
private function prepareJsonDeserializer()
129+
private function prepareJsonDeserializer(): DeserializerJson
130130
{
131131
/** @var Decoder|MockObject $decoder */
132132
$decoder = $this->createMock(Decoder::class);
@@ -141,7 +141,7 @@ private function prepareJsonDeserializer()
141141
*
142142
* @return DeserializerXml
143143
*/
144-
private function prepareXmlDeserializer()
144+
private function prepareXmlDeserializer(): DeserializerXml
145145
{
146146
$parserXml = new ParserXml();
147147
/** @var State|MockObject $appStateMock */

0 commit comments

Comments
 (0)