Skip to content

Commit 696f423

Browse files
ENGCOM-8189: #1794: [MFTF] Unskip AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest #29895
- Merge Pull Request #29895 from joweecaquicla/magento2:ASI-1794-unskip-admin-media-gallery-catalog-ui-verify-used-in-link-category-grid-test - Merged commits: 1. 96ea4d5 2. cbca032 3. ef4813c 4. 86e9656 5. f3ea93f 6. 8cea7c9 7. 27a9bef 8. 811861c 9. 225f554 10. 65690bc 11. e31ab00 12. 2485935 13. a7a1038
2 parents 8aa1d46 + a7a1038 commit 696f423

File tree

4 files changed

+34
-15
lines changed

4 files changed

+34
-15
lines changed

app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/ActionGroup/AssertAdminCategoryGridPageImageColumnActionGroup.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,11 @@
1515
<description>Assert category grid page image column a specific category</description>
1616
</annotations>
1717

18-
<seeElement selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.image(file)}}" stepKey="assertImageColumn"/>
18+
<grabAttributeFrom selector="{{AdminMediaGalleryCatalogUiCategoryGridSection.image}}" userInput="src"
19+
stepKey="getImageSrc"/>
20+
<assertStringContainsString stepKey="assertImageSrc">
21+
<actualResult type="string">{$getImageSrc}</actualResult>
22+
<expectedResult type="string">{{file}}</expectedResult>
23+
</assertStringContainsString>
1924
</actionGroup>
2025
</actionGroups>

app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/Section/AdminMediaGalleryCatalogUiCategoryGridSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<section name="AdminMediaGalleryCatalogUiCategoryGridSection">
1212
<element name="clearFilters" type="button" selector=".admin__data-grid-header [data-action='grid-filter-reset']" timeout="30"/>
1313
<element name="activeFilterPlaceholder" type="text" selector="//div[@class='admin__current-filters-list-wrap']//li//span[contains(text(), '{{filterPlaceholder}}')]" parameterized="true"/>
14-
<element name="image" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Image')]/preceding-sibling::th) +1]//img[contains(@src, '{{file}}')]" parameterized="true"/>
14+
<element name="image" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Image')]/preceding-sibling::th) +1]//img"/>
1515
<element name="columnValue" type="text" selector="//tr//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., '{{columnName}}')]/preceding-sibling::th) +1 ]//div" parameterized="true"/>
1616
<element name="edit" type="button" selector="//tr[td//text()[contains(., '{{categoryName}}')]]//td[count(//div[@data-role='grid-wrapper']//tr//th[contains(., 'Action')]/preceding-sibling::th) +1 ]//*[text()='{{actionButton}}']" parameterized="true"/>
1717
</section>

app/code/Magento/MediaGalleryCatalogUi/Test/Mftf/Test/AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest.xml

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1010
<test name="AdminMediaGalleryCatalogUiVerifyUsedInLinkCategoryGridTest">
1111
<annotations>
12-
<skip>
13-
<issueId value="https://github.com/magento/adobe-stock-integration/issues/1794"/>
14-
</skip>
1512
<features value="AdminMediaGalleryCategoryGrid"/>
1613
<useCaseId value="https://github.com/magento/adobe-stock-integration/issues/1503"/>
1714
<title value="User can open each entity the asset is associated with in a separate tab to manage association"/>
@@ -26,19 +23,30 @@
2623
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
2724
</before>
2825
<after>
29-
<actionGroup ref="AdminEnhancedMediaGalleryEnableMassActionModeActionGroup" stepKey="enableMassActionToDeleteImages"/>
30-
<actionGroup ref="AdminEnhancedMediaGallerySelectImageForMassActionActionGroup" stepKey="selectSecondImageToDelete">
31-
<argument name="imageName" value="{{UpdatedImageDetails.title}}"/>
26+
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/>
27+
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectFolderForDelete">
28+
<argument name="name" value="categoryImage"/>
29+
</actionGroup>
30+
<actionGroup ref="AdminMediaGalleryFolderDeleteActionGroup" stepKey="deleteFolder"/>
31+
<actionGroup ref="AdminMediaGalleryAssertFolderDoesNotExistActionGroup" stepKey="assertFolderWasDeleted">
32+
<argument name="name" value="categoryImage"/>
3233
</actionGroup>
33-
<actionGroup ref="AdminEnhancedMediaGalleryClickDeleteImagesButtonActionGroup" stepKey="clikDeleteSelectedButton"/>
34-
<actionGroup ref="AdminEnhancedMediaGalleryConfirmDeleteImagesActionGroup" stepKey="deleteImages"/>
3534
</after>
36-
3735
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="openCategoryPage"/>
3836
<actionGroup ref="AdminCategoriesOpenCategoryActionGroup" stepKey="openCategory">
3937
<argument name="category" value="$$category$$"/>
4038
</actionGroup>
4139
<actionGroup ref="AdminOpenMediaGalleryFromCategoryImageUploaderActionGroup" stepKey="openMediaGalleryFromImageUploader"/>
40+
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear" />
41+
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetCategoryImageGalleryGridToDefaultView"/>
42+
<actionGroup ref="ClearFiltersAdminDataGridActionGroup" stepKey="clearFilter"/>
43+
<actionGroup ref="AdminMediaGalleryOpenNewFolderFormActionGroup" stepKey="openNewFolderForm"/>
44+
<actionGroup ref="AdminMediaGalleryCreateNewFolderActionGroup" stepKey="createCategoryImageFolder">
45+
<argument name="name" value="categoryImage"/>
46+
</actionGroup>
47+
<actionGroup ref="AdminMediaGalleryAssertFolderNameActionGroup" stepKey="assertCategoryImageFolderCreated">
48+
<argument name="name" value="categoryImage"/>
49+
</actionGroup>
4250
<actionGroup ref="AdminEnhancedMediaGalleryUploadImageActionGroup" stepKey="uploadImage">
4351
<argument name="image" value="ImageUpload"/>
4452
</actionGroup>
@@ -51,6 +59,10 @@
5159
<actionGroup ref="AdminMediaGalleryClickAddSelectedActionGroup" stepKey="clickAddSelectedCategoryImage"/>
5260
<actionGroup ref="AdminSaveCategoryActionGroup" stepKey="saveCategory"/>
5361
<actionGroup ref="AdminOpenMediaGalleryFromCategoryImageUploaderActionGroup" stepKey="openMediaGalleryFromImageUploaderToVerifyLink"/>
62+
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="selectCategoryImageFolder">
63+
<argument name="name" value="categoryImage"/>
64+
</actionGroup>
65+
<waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear2"/>
5466
<actionGroup ref="AdminEnhancedMediaGalleryViewImageDetails" stepKey="openViewImageDetails"/>
5567
<actionGroup ref="AdminEnhancedMediaGalleryClickEntityUsedInActionGroup" stepKey="clickUsedInCategories">
5668
<argument name="entityName" value="Categories"/>
@@ -80,13 +92,15 @@
8092
<actionGroup ref="AssertAdminMediaGalleryAssetFilterPlaceHolderActionGroup" stepKey="assertFilterAppliedAfterUrlFilterApplier">
8193
<argument name="filterPlaceholder" value="{{UpdatedImageDetails.title}}"/>
8294
</actionGroup>
83-
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="resetAdminDataGridToDefaultView"/>
95+
<actionGroup ref="ResetAdminDataGridToDefaultViewActionGroup" stepKey="secondResetAdminDataGridToDefaultView"/>
8496

8597
<deleteData createDataKey="category" stepKey="deleteCategory"/>
8698
<actionGroup ref="AdminOpenStandaloneMediaGalleryActionGroup" stepKey="openMediaGallery"/>
87-
<actionGroup ref="AdminEnhancedMediaGalleryViewImageDetails" stepKey="openViewImageDetailsToVerfifyEmptyUsedIn"/>
99+
<actionGroup ref="AdminMediaGalleryFolderSelectActionGroup" stepKey="openCategoryImageFolder">
100+
<argument name="name" value="categoryImage"/>
101+
</actionGroup>
102+
<actionGroup ref="AdminEnhancedMediaGalleryViewImageDetails" stepKey="openViewImageDetailsToVerifyEmptyUsedIn"/>
88103
<actionGroup ref="AssertAdminEnhancedMediaGalleryUsedInSectionNotDisplayedActionGroup" stepKey="assertThereIsNoUsedInSection"/>
89104
<actionGroup ref="AdminEnhancedMediaGalleryCloseViewDetailsActionGroup" stepKey="closeDetails"/>
90-
91105
</test>
92106
</tests>

app/code/Magento/MediaGalleryUi/Test/Mftf/Data/AdminEnhancedMediaGalleryImageData.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<data key="fileName">png</data>
2525
<data key="extension">png</data>
2626
</entity>
27-
<entity name="ImageUploadGif" type="uploadImage">
27+
<entity name="ImageUploadGif" type="uploadImage">
2828
<data key="title" unique="suffix">Image1</data>
2929
<data key="file_type">Upload File</data>
3030
<data key="value">gif.gif</data>

0 commit comments

Comments
 (0)