Skip to content

Commit 6bb8158

Browse files
AnnaAPakAnnaAPak
committed
AddOutOfStockProductToCompareListTest refactored
1 parent f472536 commit 6bb8158

File tree

2 files changed

+72
-67
lines changed

2 files changed

+72
-67
lines changed

‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontHoverProductOnCategoryPageActionGroup.xml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="StorefrontHoverProductOnCategoryPageActionGroup">
12+
<annotations>
13+
<description>Hover product on the Category page</description>
14+
</annotations>
15+
16+
<moveMouseOver selector="{{StorefrontCategoryMainSection.ProductItemInfo}}" stepKey="hoverOverProduct"/>
17+
18+
</actionGroup>
19+
</actionGroups>

‎app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml

Lines changed: 53 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
<group value="Catalog"/>
2121
</annotations>
2222
<before>
23-
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
2423
<magentoCLI command="config:set {{CatalogInventoryOptionsShowOutOfStockDisable.path}} {{CatalogInventoryOptionsShowOutOfStockDisable.value}}" stepKey="setConfigShowOutOfStockFalse"/>
2524
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
2625
<argument name="tags" value=""/>
@@ -30,81 +29,68 @@
3029
<requiredEntity createDataKey="category"/>
3130
</createData>
3231
</before>
32+
3333
<after>
34-
<magentoCLI command="config:set {{CatalogInventoryOptionsShowOutOfStockDisable.path}} {{CatalogInventoryOptionsShowOutOfStockDisable.value}}" stepKey="setConfigShowOutOfStockFalse"/>
34+
<magentoCLI command="config:set {{CatalogInventoryOptionsShowOutOfStockDisable.path}} {{CatalogInventoryOptionsShowOutOfStockDisable.value}}" stepKey="setConfigShowOutOfStockFalse"/>
3535
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
3636
<argument name="tags" value=""/>
3737
</actionGroup>
38-
<deleteData createDataKey="product" stepKey="deleteProduct"/>
39-
<deleteData createDataKey="category" stepKey="deleteCategory"/>
40-
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
38+
<deleteData createDataKey="product" stepKey="deleteProduct"/>
39+
<deleteData createDataKey="category" stepKey="deleteCategory"/>
4140
</after>
42-
<!--Open product page-->
43-
<comment userInput="Open product page" stepKey="openProdPage"/>
44-
<amOnPage url="{{StorefrontProductPage.url($$product.custom_attributes[url_key]$$)}}" stepKey="goToSimpleProductPage"/>
45-
<waitForPageLoad stepKey="waitForSimpleProductPage"/>
46-
<!--'Add to compare' link is not available-->
47-
<comment userInput="'Add to compare' link is not available" stepKey="addToCompareLinkAvailability"/>
41+
42+
<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openProductStorefront">
43+
<argument name="productUrl" value="$$product.custom_attributes[url_key]$$"/>
44+
</actionGroup>
45+
4846
<dontSeeElement selector="{{StorefrontProductInfoMainSection.productAddToCompare}}" stepKey="dontSeeAddToCompareLink"/>
49-
<!--Turn on 'out on stock' config-->
50-
<comment userInput="Turn on 'out of stock' config" stepKey="onOutOfStockConfig"/>
47+
5148
<magentoCLI command="config:set {{CatalogInventoryOptionsShowOutOfStockEnable.path}} {{CatalogInventoryOptionsShowOutOfStockEnable.value}}" stepKey="setConfigShowOutOfStockTrue"/>
52-
<!--Clear cache and reindex-->
53-
<comment userInput="Clear cache and reindex" stepKey="cleanCache"/>
49+
5450
<actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex">
55-
<argument name="indices" value=""/>
56-
</actionGroup>
51+
<argument name="indices" value=""/>
52+
</actionGroup>
5753
<actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
58-
<argument name="tags" value=""/>
59-
</actionGroup>
60-
<!--Open product page-->
61-
<comment userInput="Open product page" stepKey="openProductPage"/>
62-
<amOnPage url="{{StorefrontProductPage.url($$product.custom_attributes[url_key]$$)}}" stepKey="goToSimpleProductPage2"/>
63-
<waitForPageLoad stepKey="waitForSimpleProductPage2"/>
64-
<!--Click on 'Add to Compare' link-->
65-
<waitForElementVisible selector="{{StorefrontProductInfoMainSection.productAddToCompare}}" stepKey="seeAddToCompareLink"/>
66-
<comment userInput="Click on 'Add to Compare' link" stepKey="clickOnAddToCompareLink"/>
67-
<click selector="{{StorefrontProductInfoMainSection.productAddToCompare}}" stepKey="clickOnAddToCompare"/>
68-
<waitForPageLoad stepKey="waitForProdAddToCmpList"/>
69-
<!--Assert success message-->
70-
<comment userInput="Assert success message" stepKey="assertSuccessMsg"/>
71-
<grabTextFrom selector="{{StorefrontMessagesSection.success}}" stepKey="grabTextFromSuccessMessage"/>
72-
<assertEquals stepKey="assertSuccessMessage">
73-
<actualResult type="const">($grabTextFromSuccessMessage)</actualResult>
74-
<expectedResult type="string">You added product $$product.name$$ to the comparison list.</expectedResult>
75-
</assertEquals>
76-
<!--See product in the comparison list-->
77-
<comment userInput="See product in the comparison list" stepKey="seeProductInComparisonList"/>
78-
<amOnPage url="{{StorefrontProductComparePage.url}}" stepKey="navigateToComparePage"/>
79-
<waitForPageLoad stepKey="waitForStorefrontProductComparePageLoad"/>
80-
<seeElement selector="{{StorefrontProductCompareMainSection.ProductLinkByName($product.name$)}}" stepKey="seeProductInCompareList"/>
81-
<!--Go to Category page and delete product from comparison list-->
82-
<comment userInput="Go to Category page and delete product from comparison list" stepKey="deleteProdFromCmpList"/>
83-
<amOnPage url="{{StorefrontCategoryPage.url($$category.name$$)}}" stepKey="onCategoryPage"/>
84-
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>
85-
<click selector="{{StorefrontComparisonSidebarSection.ClearAll}}" stepKey="clickClearAll"/>
86-
<waitForPageLoad time="30" stepKey="waitForConfirmPageLoad"/>
87-
<click selector="{{AdminDeleteRoleSection.confirm}}" stepKey="confirmProdDelate"/>
88-
<waitForPageLoad time="30" stepKey="waitForConfirmLoad"/>
89-
<!--Add product to compare list from Category page-->
90-
<comment userInput="Add product to compare list fom Category page" stepKey="addToCmpFromCategPage"/>
91-
<moveMouseOver selector="{{StorefrontCategoryMainSection.ProductItemInfo}}" stepKey="hoverOverProduct"/>
92-
<click selector="{{StorefrontProductInfoMainSection.productAddToCompare}}" stepKey="clickAddToCompare"/>
93-
<waitForPageLoad stepKey="waitProdAddingToCmpList"/>
94-
<!--Assert success message-->
95-
<comment userInput="Assert success message" stepKey="assertSuccessMsg2"/>
96-
<grabTextFrom selector="{{StorefrontMessagesSection.success}}" stepKey="grabTextFromSuccessMessage2"/>
97-
<assertEquals stepKey="assertSuccessMessage2">
98-
<actualResult type="const">($grabTextFromSuccessMessage)</actualResult>
99-
<expectedResult type="string">You added product $$product.name$$ to the comparison list.</expectedResult>
100-
</assertEquals>
101-
<!--Check that product displays on add to compare widget-->
102-
<comment userInput="Check that product displays on add to compare widget" stepKey="checkProdNameOnWidget"/>
54+
<argument name="tags" value=""/>
55+
</actionGroup>
56+
57+
<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openProductStorefront1">
58+
<argument name="productUrl" value="$$product.custom_attributes[url_key]$$"/>
59+
</actionGroup>
60+
61+
<actionGroup ref="StorefrontAddProductToCompareActionGroup" stepKey="addProductToCompare1">
62+
<argument name="productVar" value="$$product$$"/>
63+
</actionGroup>
64+
65+
<actionGroup ref="StorefrontGoToCategoryPageActionGroup" stepKey="openCategoryPage">
66+
<argument name="categoryName" value="$$category.name$$"/>
67+
</actionGroup>
68+
69+
<actionGroup ref="StorefrontOpenAndCheckComparisionActionGroup" stepKey="compareOpenComparePage"/>
70+
71+
<actionGroup ref="SeeProductInComparisonListActionGroup" stepKey="seeProductInComparisonList">
72+
<argument name="productVar" value="$$product$$"/>
73+
</actionGroup>
74+
75+
<actionGroup ref="StorefrontGoToCategoryPageActionGroup" stepKey="openCategoryPage1">
76+
<argument name="categoryName" value="$$category.name$$"/>
77+
</actionGroup>
78+
79+
<actionGroup ref="StorefrontClearCompareActionGroup" stepKey="clearList"/>
80+
81+
<actionGroup ref="StorefrontHoverProductOnCategoryPageActionGroup" stepKey="hoverProduct"/>
82+
83+
<actionGroup ref="StorefrontAddProductToCompareActionGroup" stepKey="addProductToCompare2">
84+
<argument name="productVar" value="$$product$$"/>
85+
</actionGroup>
86+
10387
<seeElement selector="{{StorefrontComparisonSidebarSection.ProductTitleByName($$product.name$$)}}" stepKey="seeProdNameOnCmpWidget"/>
104-
<!--See product in the compare page-->
105-
<comment userInput="See product in the compare page" stepKey="seeProductInComparePage"/>
106-
<amOnPage url="{{StorefrontProductComparePage.url}}" stepKey="navigateToComparePage2"/>
107-
<waitForPageLoad stepKey="waitForStorefrontProductComparePageLoad2"/>
108-
<seeElement selector="{{StorefrontProductCompareMainSection.ProductLinkByName($product.name$)}}" stepKey="seeProductInCompareList2"/>
88+
89+
<actionGroup ref="StorefrontOpenAndCheckComparisionActionGroup" stepKey="compareOpenComparePage1"/>
90+
91+
<actionGroup ref="SeeProductInComparisonListActionGroup" stepKey="seeProductInComparisonList1">
92+
<argument name="productVar" value="$$product$$"/>
93+
</actionGroup>
94+
10995
</test>
11096
</tests>

0 commit comments

Comments
 (0)