improve fix Allow customer to specify associated product qtys when adding grouped product to cart via RESTful API

Author: engcom-Charlie

app/code/Magento/GroupedProduct/Api/Data/GroupedOptionsInterface.php

@@ -24,9 +24,9 @@ public function getId(): int;
     /**
      * Get associated product qty
      *
-     * @return float
+     * @return int
      */
-    public function getQty(): float;
+    public function getQty(): int;
 
     /**
      * Set extension attributes

app/code/Magento/GroupedProduct/Model/Quote/Item/CartItemProcessor.php

@@ -9,9 +9,6 @@
 
 use Magento\Framework\DataObject;
 use Magento\Framework\DataObject\Factory as ObjectFactory;
-use Magento\Framework\Serialize\Serializer\Json;
-use Magento\GroupedProduct\Api\Data\GroupedOptionsInterface;
-use Magento\GroupedProduct\Api\Data\GroupedOptionsInterfaceFactory;
 use Magento\GroupedProduct\Model\Product\Type\Grouped;
 use Magento\Quote\Api\Data as QuoteApi;
 use Magento\Quote\Api\Data\CartItemInterface;
@@ -29,16 +26,6 @@ class CartItemProcessor implements CartItemProcessorInterface
      */
     private $objectFactory;
 
-    /**
-     * @var GroupedOptionsInterface
-     */
-    private $groupedOptionFactory;
-
-    /**
-     * @var Json
-     */
-    private $jsonSerializer;
-
     /**
      * @var QuoteApi\ProductOptionExtensionFactory
      */
@@ -56,21 +43,15 @@ class CartItemProcessor implements CartItemProcessorInterface
 
     /**
      * @param ObjectFactory $objectFactory
-     * @param GroupedOptionsInterfaceFactory $groupedOptionFactory
-     * @param Json $jsonSerializer
      * @param QuoteApi\ProductOptionExtensionFactory $productOptionExtensionFactory
      * @param QuoteApi\ProductOptionInterfaceFactory $productOptionFactory
      */
     public function __construct(
         ObjectFactory $objectFactory,
-        GroupedOptionsInterfaceFactory $groupedOptionFactory,
-        Json $jsonSerializer,
         QuoteApi\ProductOptionExtensionFactory $productOptionExtensionFactory,
         QuoteApi\ProductOptionInterfaceFactory $productOptionFactory
     ) {
         $this->objectFactory = $objectFactory;
-        $this->groupedOptionFactory = $groupedOptionFactory;
-        $this->jsonSerializer = $jsonSerializer;
         $this->productOptionExtensionFactory = $productOptionExtensionFactory;
         $this->productOptionFactory = $productOptionFactory;
     }
@@ -83,21 +64,19 @@ public function __construct(
      */
     public function convertToBuyRequest(CartItemInterface $cartItem): ?DataObject
     {
-        $extensionAttributes = $cartItem->getProductOption()
-            ? $cartItem->getProductOption()->getExtensionAttributes()
-            : null;
-        if ($extensionAttributes) {
-            $groupedOptions = $extensionAttributes->getGroupedOptions();
-            if ($groupedOptions) {
-                $this->groupedOptions = $groupedOptions;
-                $requestData = [];
-
-                foreach ($groupedOptions as $item) {
-                    $requestData[self::SUPER_GROUP_CODE][$item->getId()] = $item->getQty();
-                }
-
-                return $this->objectFactory->create($requestData);
+        if ($cartItem->getProductOption()
+            && $cartItem->getProductOption()->getExtensionAttributes()
+            && $cartItem->getProductOption()->getExtensionAttributes()->getGroupedOptions()
+        ) {
+            $groupedOptions = $cartItem->getProductOption()->getExtensionAttributes()->getGroupedOptions();
+            $this->groupedOptions = $groupedOptions;
+
+            $requestData = [];
+            foreach ($groupedOptions as $item) {
+                $requestData[self::SUPER_GROUP_CODE][$item->getId()] = $item->getQty();
             }
+
+            return $this->objectFactory->create($requestData);
         }
 
         return null;

app/code/Magento/GroupedProduct/Model/Quote/Item/GroupedOptions.php

@@ -16,7 +16,7 @@
 class GroupedOptions implements GroupedOptionsInterface
 {
     /**
-     * @var float
+     * @var int
      */
     private $qty;
 
@@ -32,10 +32,10 @@ class GroupedOptions implements GroupedOptionsInterface
 
     /**
      * @param int $id
-     * @param float $qty
+     * @param int $qty
      * @param GroupedOptionsExtensionInterface|null $extensionAttributes
      */
-    public function __construct(int $id, float $qty, $extensionAttributes = null)
+    public function __construct(int $id, int $qty, $extensionAttributes = null)
     {
         $this->id = $id;
         $this->qty = $qty;
@@ -53,7 +53,7 @@ public function getId(): int
     /**
      * @inheritDoc
      */
-    public function getQty(): float
+    public function getQty(): int
     {
         return $this->qty;
     }