#29889: Code review and static tests fixes

Author: sivaschenko

app/code/Magento/MediaGalleryRenditions/Model/Config.php

@@ -34,6 +34,7 @@ class Config
 
     /**
      * @param ScopeConfigInterface $scopeConfig
+     * @param ResourceConnection $resourceConnection
      */
     public function __construct(
         ScopeConfigInterface $scopeConfig,

app/code/Magento/MediaGalleryRenditions/Model/GenerateRenditions.php

@@ -64,6 +64,8 @@ class GenerateRenditions implements GenerateRenditionsInterface
      * @param GetRenditionPathInterface $getRenditionPath
      * @param Filesystem $filesystem
      * @param File $driver
+     * @param IsPathExcludedInterface $isPathExcluded
+     * @param LoggerInterface $log
      */
     public function __construct(
         AdapterFactory $imageFactory,
@@ -121,6 +123,8 @@ public function execute(array $paths): void
      */
     private function generateRendition(string $path): void
     {
+        $this->validateAsset($path);
+
         $renditionPath = $this->getRenditionPath->execute($path);
         $this->createDirectory($renditionPath);
 
@@ -137,6 +141,8 @@ private function generateRendition(string $path): void
     }
 
     /**
+     * Ensure valid media asset path is provided for renditions generation
+     *
      * @param string $path
      * @throws FileSystemException
      * @throws LocalizedException

app/code/Magento/MediaGalleryRenditions/Model/Queue/FetchRenditionPathsBatches.php

@@ -44,7 +44,7 @@ class FetchRenditionPathsBatches
     /**
      * @param LoggerInterface $log
      * @param Filesystem $filesystem
-     * @param GetFilesIterator $assetsIterator
+     * @param GetFilesIterator $getFilesIterator
      * @param int $batchSize
      * @param array $fileExtensions
      */

app/code/Magento/MediaGalleryRenditions/Model/Queue/UpdateRenditions.php

@@ -69,7 +69,7 @@ public function execute(array $paths): void
     /**
      * Update renditions and log exceptions
      *
-     * @param string[] $paths
+     * @param string[] $renditionPaths
      */
     private function updateRenditions(array $renditionPaths): void
     {

app/code/Magento/MediaGalleryRenditions/Plugin/RemoveRenditions.php

@@ -52,15 +52,15 @@ public function __construct(
      * Remove renditions when assets are removed
      *
      * @param DeleteAssetsByPathsInterface $deleteAssetsByPaths
-     * @param \Closure $proceed
+     * @param null $result
      * @param array $paths
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function aroundExecute(
+    public function afterExecute(
         DeleteAssetsByPathsInterface $deleteAssetsByPaths,
-        \Closure $proceed,
+        $result,
         array $paths
     ): void {
-        $proceed($paths);
         $this->removeRenditions($paths);
     }
 

app/code/Magento/MediaGalleryRenditions/Plugin/UpdateRenditionsOnConfigChange.php

@@ -54,7 +54,7 @@ public function afterSave(Value $config, Value $result): Value
      * @param Value $value
      * @return bool
      */
-    private function isRenditionsValue(Value $value)
+    private function isRenditionsValue(Value $value): bool
     {
         return $value->getPath() === self::XML_PATH_MEDIA_GALLERY_RENDITIONS_WIDTH_PATH
             || $value->getPath() === self::XML_PATH_MEDIA_GALLERY_RENDITIONS_HEIGHT_PATH;

app/code/Magento/MediaGalleryRenditions/composer.json

@@ -5,7 +5,9 @@
         "php": "~7.3.0||~7.4.0",
         "magento/framework": "*",
         "magento/module-media-gallery-renditions-api": "*",
+        "magento/module-media-gallery-api": "*",
         "magento/module-media-content-api": "*",
+        "magento/framework-message-queue": "*",
         "magento/module-cms": "*"
     },
     "type": "magento2-module",

app/code/Magento/MediaGalleryRenditions/etc/media_content.xml

@@ -15,4 +15,4 @@
             <pattern name="catalog_image_with_pub">/^\/pub\/?media\/(?:.renditions\/)?(.*)/</pattern>
         </patterns>
     </search>
-</config>
+</config>

app/code/Magento/MediaGalleryRenditionsApi/Api/GenerateRenditionsInterface.php

@@ -9,6 +9,9 @@
 
 use Magento\Framework\Exception\LocalizedException;
 
+/**
+ * Generate optimized version of media assets based on configuration for insertion to content
+ */
 interface GenerateRenditionsInterface
 {
     /**

app/code/Magento/MediaGalleryRenditionsApi/Api/GetRenditionPathInterface.php

@@ -9,6 +9,9 @@
 
 use Magento\Framework\Exception\LocalizedException;
 
+/**
+ * Based on media assset path provides path to an optimized image version for insertion to the content
+ */
 interface GetRenditionPathInterface
 {
     /**