Merge pull request #8315 from magento-l3/AC-8862

AC-8862: Config path which contains capital letters doesn't return value

Author: dhorytskyi

app/code/Magento/Config/Model/Config/Reader/Source/Deployed/SettingChecker.php

@@ -102,12 +102,8 @@ public function getPlaceholderValue($path, $scope, $scopeCode = null)
     public function getEnvValue($placeholder)
     {
         // phpcs:disable Magento2.Security.Superglobal
-        $environment = [];
-        foreach ($_ENV as $key => $value) {
-            $environment[strtolower($key)] = $value;
-        }
-        if ($this->placeholder->isApplicable($placeholder) && isset($environment[strtolower($placeholder)])) {
-            return $environment[strtolower($placeholder)];
+        if ($this->placeholder->isApplicable($placeholder) && isset($_ENV[$placeholder])) {
+            return $_ENV[$placeholder];
         }
         // phpcs:enable
 

app/code/Magento/Config/Test/Unit/Model/Config/Reader/Source/Deployed/SettingCheckerTest.php

@@ -69,16 +69,6 @@ protected function setUp(): void
         $this->checker = new SettingChecker($this->configMock, $placeholderFactoryMock, $this->scopeCodeResolverMock);
     }
 
-    public function testGetEnvValue(): void
-    {
-        $_ENV = array_merge($this->env, ['SOME_PLACEHOLDER' => 0, 'another_placeholder' => 1, 'some_placeholder' => 1]);
-        $this->placeholderMock->expects($this->any())
-            ->method('isApplicable')
-            ->willReturn(true);
-        $this->assertSame($this->checker->getEnvValue('SOME_PLACEHOLDER'), 1);
-        $this->assertSame($this->checker->getEnvValue('another_placeholder'), 1);
-    }
-
     /**
      * @param string $path
      * @param string $scope

app/code/Magento/Store/App/Config/Source/RuntimeConfigSource.php

@@ -102,7 +102,7 @@ private function getEntities($table, $keyField)
         );
 
         foreach ($entities as $entity) {
-            $data[strtolower($entity[$keyField])] = $entity;
+            $data[$entity[$keyField]] = $entity;
         }
 
         return $data;

app/code/Magento/Store/App/Config/Type/Scopes.php

@@ -72,7 +72,7 @@ public function get($path = '')
             $path = $this->convertIdPathToCodePath($patchChunks);
         }
 
-        return $this->data->getData(strtolower($path));
+        return $this->data->getData($path);
     }
 
     /**

app/code/Magento/Store/Model/Config/Processor/Fallback.php

@@ -11,7 +11,10 @@
 use Magento\Framework\DB\Adapter\TableNotFoundException;
 use Magento\Store\App\Config\Type\Scopes;
 use Magento\Store\Model\ResourceModel\Store;
+use Magento\Store\Model\ResourceModel\Store\AllStoresCollectionFactory;
 use Magento\Store\Model\ResourceModel\Website;
+use Magento\Store\Model\ResourceModel\Website\AllWebsitesCollection;
+use Magento\Store\Model\ResourceModel\Website\AllWebsitesCollectionFactory;
 
 /**
  * Fallback through different scopes and merge them
@@ -111,13 +114,6 @@ private function prepareWebsitesConfig(
         array $websitesConfig
     ) {
         $result = [];
-
-        foreach ($websitesConfig as $websiteCode => $webConfiguration) {
-            if (!isset($websitesConfig[strtolower($websiteCode)])) {
-                $websitesConfig[strtolower($websiteCode)] = $webConfiguration;
-                unset($websitesConfig[$websiteCode]);
-            }
-        }
         foreach ((array)$this->websiteData as $website) {
             $code = $website['code'];
             $id = $website['website_id'];
@@ -143,12 +139,6 @@ private function prepareStoresConfig(
     ) {
         $result = [];
 
-        foreach ($storesConfig as $storeCode => $storeConfiguration) {
-            if (!isset($storesConfig[strtolower($storeCode)])) {
-                $storesConfig[strtolower($storeCode)] = $storeConfiguration;
-                unset($storesConfig[$storeCode]);
-            }
-        }
         foreach ((array)$this->storeData as $store) {
             $code = $store['code'];
             $id = $store['store_id'];
@@ -201,18 +191,5 @@ private function loadScopes(): void
             $this->storeData = [];
             $this->websiteData = [];
         }
-        $this->normalizeStoreData();
-    }
-
-    /**
-     * Sets stores code to lower case
-     *
-     * @return void
-     */
-    private function normalizeStoreData(): void
-    {
-        foreach ($this->storeData as $key => $store) {
-            $this->storeData[$key]['code'] = strtolower($store['code']);
-        }
     }
 }

app/code/Magento/Store/Test/Unit/App/Config/Source/RuntimeConfigSourceTest.php

@@ -68,73 +68,12 @@ public function testGet()
             ->getMock();
         $selectMock->expects($this->any())->method('from')->willReturnSelf();
         $this->connection->expects($this->any())->method('select')->willReturn($selectMock);
-        $this->connection->expects($this->exactly(3))->method('fetchAll')
-            ->willReturnOnConsecutiveCalls(
-                [
-                    'WebsiteCode' => [
-                        'website_id' => '3',
-                        'code' => 'WebsiteCode',
-                        'name' => 'website',
-                        'sort_order' => '0',
-                        'default_group_id' => '4',
-                        'is_default' => '0'
-                    ]
-                ],
-                [
-                    0 => [
-                        'group_id' => '4',
-                        'website_id' => '3',
-                        'name' => 'store',
-                        'root_category_id' => '2',
-                        'default_store_id' => '11',
-                        'code' => 'second_website'
-                    ]
-                ],
-                [
-                    'SecondWebsite' => [
-                        'store_id' => '11',
-                        'code' => 'SECOND_WEBSITE',
-                        'website_id' => '3',
-                        'group_id' => '4',
-                        'name' => 'second',
-                        'sort_order' => '0',
-                        'is_active' => '1'
-                    ]
-                ]
-            );
+        $this->connection->expects($this->any())->method('fetchAll')->willReturn([]);
         $this->assertEquals(
             [
-                'websites' => [
-                    'websitecode' => [
-                        'website_id' => '3',
-                        'code' => 'WebsiteCode',
-                        'name' => 'website',
-                        'sort_order' => '0',
-                        'default_group_id' => '4',
-                        'is_default' => '0'
-                    ]
-                ],
-                'groups' => [
-                    4 => [
-                        'group_id' => '4',
-                        'website_id' => '3',
-                        'name' => 'store',
-                        'root_category_id' => '2',
-                        'default_store_id' => '11',
-                        'code' => 'second_website'
-                    ]
-                ],
-                'stores' => [
-                    'second_website' => [
-                        'store_id' => '11',
-                        'code' => 'SECOND_WEBSITE',
-                        'website_id' => '3',
-                        'group_id' => '4',
-                        'name' => 'second',
-                        'sort_order' => '0',
-                        'is_active' => '1'
-                    ]
-                ],
+                'websites' => [],
+                'groups' => [],
+                'stores' => [],
             ],
             $this->configSource->get()
         );

app/code/Magento/Store/Test/Unit/Model/Config/Processor/FallbackTest.php

@@ -1,5 +1,6 @@
 <?php
 /**
+ *
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
@@ -125,7 +126,6 @@ public function clean()
      */
     public function get($configType, $path = '', $default = null)
     {
-        $path = strtolower($path);
         $result = null;
         if (isset($this->types[$configType])) {
             $result = $this->types[$configType]->get($path);

lib/internal/Magento/Framework/App/Config.php

@@ -59,10 +59,9 @@ public function resolve($scopeType, $scopeCode)
             $scopeCode = $resolverScopeCode;
         }
 
-        $this->resolvedScopeCodes[$scopeType][$scopeCode] =
-            is_null($resolverScopeCode) ? null : strtolower($resolverScopeCode);
+        $this->resolvedScopeCodes[$scopeType][$scopeCode] = $resolverScopeCode;
 
-        return $this->resolvedScopeCodes[$scopeType][$scopeCode];
+        return $resolverScopeCode;
     }
 
     /**

lib/internal/Magento/Framework/App/Config/ScopeCodeResolver.php

@@ -67,6 +67,6 @@ public function testResolve()
         $this->scope->expects($this->once())
             ->method('getCode')
             ->willReturn($scopeCode);
-        $this->assertEquals(strtolower($scopeCode), $this->scopeCodeResolver->resolve($scopeType, $scopeId));
+        $this->assertEquals($scopeCode, $this->scopeCodeResolver->resolve($scopeType, $scopeId));
     }
 }

lib/internal/Magento/Framework/App/Test/Unit/Config/ScopeCodeResolverTest.php

@@ -71,7 +71,7 @@ public function testGetValue($scope, $scopeCode = null)
         }
         $this->configType->expects($this->once())
             ->method('get')
-            ->with($scope =='store' ? 'stores/path' : 'websites/mywebsite/path')
+            ->with($scope =='store' ? 'stores/path' : 'websites/myWebsite/path')
             ->willReturn(true);
 
         $this->assertTrue($this->appConfig->getValue($path, $scope, $scopeCode ?: $this->scope));
@@ -84,7 +84,7 @@ public function getValueDataProvider()
     {
         return [
             ['store', 1],
-            ['website']
+            ['website'],
         ];
     }
 }