magento/adobe-stock-integration#1727: Introduce internal class wrapping SplFileInfo - apply requested changes

Author: joweecaquicla

app/code/Magento/MediaGallerySynchronization/Model/CreateAssetFromFile.php

@@ -110,7 +110,7 @@ public function execute(string $path): AssetInterface
             [
                 'id' => null,
                 'path' => $path,
-                'title' => $metadata->getTitle() ?: $file->getBasename('.' . $file->getExtension()),
+                'title' => $metadata->getTitle() ?: $file->getBasename(),
                 'description' => $metadata->getDescription(),
                 'createdAt' => $this->date->date($file->getCTime())->format(self::DATE_FORMAT),
                 'updatedAt' => $this->date->date($file->getMTime())->format(self::DATE_FORMAT),

app/code/Magento/MediaGallerySynchronization/Model/Filesystem/FileInfo.php

@@ -8,11 +8,9 @@
 namespace Magento\MediaGallerySynchronization\Model\Filesystem;
 
 /**
- * Internal class wrapping \SplFileInfo
- *
- * @SuppressWarnings(PHPMD.TooManyFields)
+ * Class for getting image file information.
  */
-class FileInfo extends \SplFileInfo
+class FileInfo
 {
     /**
      * @var string
@@ -34,36 +32,11 @@ class FileInfo extends \SplFileInfo
      */
     private $basename;
 
-    /**
-     * @var string
-     */
-    private $pathname;
-
-    /**
-     * @var int
-     */
-    private $inode;
-
     /**
      * @var int
      */
     private $size;
 
-    /**
-     * @var int
-     */
-    private $owner;
-
-    /**
-     * @var int
-     */
-    private $group;
-
-    /**
-     * @var int
-     */
-    private $aTime;
-
     /**
      * @var int
      */
@@ -74,178 +47,102 @@ class FileInfo extends \SplFileInfo
      */
     private $cTime;
 
-    /**
-     * @var string
-     */
-    private $type;
-
-    /**
-     * @var false|string
-     */
-    private $realPath;
-
     /**
      * FileInfo constructor.
-     * @param string $file_name
+     *
      * @param string $path
      * @param string $filename
      * @param string $extension
      * @param string $basename
-     * @param string $pathname
-     * @param int $inode
      * @param int $size
-     * @param int $owner
-     * @param int $group
-     * @param int $aTime
      * @param int $mTime
      * @param int $cTime
-     * @param string $type
-     * @param false|string $realPath
-     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
-        string $file_name,
         string $path,
         string $filename,
         string $extension,
         string $basename,
-        string $pathname,
-        int $inode,
         int $size,
-        int $owner,
-        int $group,
-        int $aTime,
         int $mTime,
-        int $cTime,
-        string $type,
-        $realPath
+        int $cTime
     ) {
-        parent::__construct($file_name);
         $this->path = $path;
         $this->filename = $filename;
         $this->extension = $extension;
         $this->basename = $basename;
-        $this->pathname = $pathname;
-        $this->inode = $inode;
         $this->size = $size;
-        $this->owner = $owner;
-        $this->group = $group;
-        $this->aTime = $aTime;
         $this->mTime = $mTime;
         $this->cTime = $cTime;
-        $this->type = $type;
-        $this->realPath = $realPath;
     }
 
     /**
-     * @inheritDoc
+     * Get path without filename.
+     *
+     * @return string
      */
     public function getPath(): string
     {
         return $this->path;
     }
 
     /**
-     * @inheritDoc
+     * Get filename.
+     *
+     * @return string
      */
     public function getFilename(): string
     {
         return $this->filename;
     }
 
     /**
-     * @inheritDoc
+     * Get file extension.
+     *
+     * @return string
      */
     public function getExtension(): string
     {
         return $this->extension;
     }
 
     /**
-     * @inheritDoc
+     * Get file basename.
+     *
+     * @return string
      */
-    public function getBasename($suffix = null): string
+    public function getBasename(): string
     {
         return $this->basename;
     }
 
     /**
-     * @inheritDoc
-     */
-    public function getPathname(): string
-    {
-        return $this->pathname;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getInode(): int
-    {
-        return $this->inode;
-    }
-
-    /**
-     * @inheritDoc
+     * Get file size.
+     *
+     * @return int
      */
     public function getSize(): int
     {
         return $this->size;
     }
 
     /**
-     * @inheritDoc
-     */
-    public function getOwner(): int
-    {
-        return $this->owner;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getGroup(): int
-    {
-        return $this->group;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getATime(): int
-    {
-        return $this->aTime;
-    }
-
-    /**
-     * @inheritDoc
+     * Get last modified time.
+     *
+     * @return int
      */
     public function getMTime(): int
     {
         return $this->mTime;
     }
 
     /**
-     * @inheritDoc
+     * Get inode change time.
+     *
+     * @return int
      */
     public function getCTime(): int
     {
         return $this->cTime;
     }
-
-    /**
-     * @inheritDoc
-     */
-    public function getType(): string
-    {
-        return $this->type;
-    }
-
-    /**
-     * @inheritDoc
-     */
-    public function getRealPath()
-    {
-        return $this->realPath;
-    }
 }

app/code/Magento/MediaGallerySynchronization/Model/Filesystem/GetFileInfo.php

@@ -40,22 +40,13 @@ public function execute(string $path): FileInfo
         $splFileInfo = new \SplFileInfo($path);
 
         return $this->fileInfoFactory->create([
-            'file_name' => $path,
             'path' => $splFileInfo->getPath(),
             'filename' => $splFileInfo->getFilename(),
             'extension' => $splFileInfo->getExtension(),
             'basename' => $splFileInfo->getBasename('.' . $splFileInfo->getExtension()),
-            'pathname' => $splFileInfo->getPathname(),
-            'perms' => $splFileInfo->getPerms(),
-            'inode' => $splFileInfo->getInode(),
             'size' => $splFileInfo->getSize(),
-            'owner' => $splFileInfo->getOwner(),
-            'group' => $splFileInfo->getGroup(),
-            'aTime' => $splFileInfo->getATime(),
             'mTime' => $splFileInfo->getMTime(),
-            'cTime' => $splFileInfo->getCTime(),
-            'type' => $splFileInfo->getType(),
-            'realPath' => $splFileInfo->getRealPath()
+            'cTime' => $splFileInfo->getCTime()
         ]);
     }
 }

app/code/Magento/MediaGallerySynchronization/Test/Integration/Model/Filesystem/GetFileInfoTest.php

@@ -40,21 +40,14 @@ public function testExecute(
         $path = $this->getImageFilePath($file);
 
         $fileInfo = $this->getFileInfo->execute($path);
-        $this->assertNotEmpty($fileInfo->getPath());
-        $this->assertNotEmpty($fileInfo->getFilename());
-        $this->assertNotEmpty($fileInfo->getExtension());
-        $this->assertNotEmpty($fileInfo->getBasename());
-        $this->assertNotEmpty($fileInfo->getPathname());
-        $this->assertNotEmpty($fileInfo->getPerms());
-        $this->assertNotEmpty($fileInfo->getInode());
-        $this->assertNotEmpty($fileInfo->getSize());
-        $this->assertNotEmpty($fileInfo->getOwner());
-        $this->assertNotEmpty($fileInfo->getGroup());
-        $this->assertNotEmpty($fileInfo->getATime());
-        $this->assertNotEmpty($fileInfo->getMTime());
-        $this->assertNotEmpty($fileInfo->getCTime());
-        $this->assertNotEmpty($fileInfo->getType());
-        $this->assertNotEmpty($fileInfo->getRealPath());
+        $expectedResult = new \SplFileInfo($path);
+        $this->assertEquals($expectedResult->getPath(), $fileInfo->getPath());
+        $this->assertEquals($expectedResult->getFilename(), $fileInfo->getFilename());
+        $this->assertEquals($expectedResult->getExtension(), $fileInfo->getExtension());
+        $this->assertEquals($expectedResult->getBasename('.' . $expectedResult->getExtension()), $fileInfo->getBasename());
+        $this->assertEquals($expectedResult->getSize(), $fileInfo->getSize());
+        $this->assertEquals($expectedResult->getMTime(), $fileInfo->getMTime());
+        $this->assertEquals($expectedResult->getCTime(), $fileInfo->getCTime());
     }
 
     /**