Skip to content

Commit 8f841a0

Browse files
committed
Cover changes with jasmine tests, cover case with hide method
1 parent a990468 commit 8f841a0

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ define([
167167
* Close image preview
168168
*/
169169
hide: function () {
170-
this.lastOpenedImage(null);
170+
this.lastOpenedImage(false);
171171
this.visibleRecord(null);
172172
this.height(0);
173173
this._selectRow(null);

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/grid/columns/image-preview.test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,18 @@ define([
5151
imagePreview.visibleRecord = ko.observable(1);
5252
});
5353

54-
describe('show method', function () {
54+
describe('verify show && hide record', function () {
55+
5556
it('show image', function () {
56-
var mockImg = document.createElement('img'),
57-
hide = spyOn(imagePreview, 'hide');
57+
var mockImg = document.createElement('img');
5858

59+
imagePreview.visibleRecord(2);
5960
spyOn($.fn, 'get').and.returnValue(mockImg);
6061
imagePreview.show(record);
61-
expect(hide).toHaveBeenCalledTimes(1);
62+
expect(imagePreview.lastOpenedImage()).toBe(record._rowIndex);
63+
64+
imagePreview.hide();
65+
expect(imagePreview.lastOpenedImage()).toBe(false);
6266
});
6367

6468
});

0 commit comments

Comments
 (0)