Skip to content

Commit 901daf6

Browse files
remove preventDefault()
1 parent e11e0a7 commit 901daf6

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

lib/internal/Magento/Framework/View/Helper/SecureHtmlRenderer.php

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace Magento\Framework\View\Helper;
1010

11-
use Magento\Framework\Api\SimpleDataObjectConverter;
1211
use Magento\Framework\Math\Random;
1312
use Magento\Framework\View\Helper\SecureHtmlRender\EventHandlerData;
1413
use Magento\Framework\View\Helper\SecureHtmlRender\HtmlRenderer;
@@ -105,27 +104,26 @@ public function renderEventListenerAsTag(
105104
}
106105

107106
$random = $this->random->getRandomString(10);
108-
$listenerFunction = 'eventListener' .$random;
109-
$elementName = 'listenedElement' .$random;
107+
$listenerFunction = 'eventListener' . $random;
108+
$elementName = 'listenedElement' . $random;
110109
$script = <<<script
111110
function {$listenerFunction} () {
112111
{$attributeJavascript};
113112
}
114113
var {$elementName}Array = document.querySelectorAll("{$elementSelector}");
115114
if({$elementName}Array.length !== 'undefined'){
116-
{$elementName}Array.forEach(function(element){
115+
{$elementName}Array.forEach(function(element) {
117116
if (element) {
118117
element.{$eventName} = function (event) {
119-
event.preventDefault();
120118
var targetElement = element;
121119
if (event && event.target) {
122120
targetElement = event.target;
123121
}
124122
{$listenerFunction}.apply(targetElement);
125-
}
123+
};
126124
}
127125
});
128-
}
126+
}
129127
script;
130128

131129
return $this->renderTag('script', ['type' => 'text/javascript'], $script, false);
@@ -145,7 +143,7 @@ public function renderStyleAsTag(string $style, string $selector): string
145143
throw new \InvalidArgumentException('Invalid style data given');
146144
}
147145

148-
$elementVariable = 'elem' .$this->random->getRandomString(8);
146+
$elementVariable = 'elem' . $this->random->getRandomString(8);
149147
/** @var string[] $styles */
150148
$stylesAssignments = '';
151149
foreach ($stylePairs as $stylePair) {
@@ -167,7 +165,7 @@ public function renderStyleAsTag(string $style, string $selector): string
167165
'script',
168166
['type' => 'text/javascript'],
169167
"var $elementVariable = document.querySelector('$selector');\n"
170-
."if ($elementVariable) {\n{$stylesAssignments}}",
168+
. "if ($elementVariable) {\n{$stylesAssignments}}",
171169
false
172170
);
173171
}

0 commit comments

Comments
 (0)