fix mftf, static

Author: engcom-Charlie

app/code/Magento/Sales/Controller/Adminhtml/Order/CreditmemoLoader.php

@@ -8,12 +8,12 @@
 
 use Magento\Framework\DataObject;
 use Magento\Sales\Api\CreditmemoRepositoryInterface;
-use \Magento\Sales\Model\Order\CreditmemoFactory;
+use Magento\Sales\Model\Order;
+use Magento\Sales\Model\Order\CreditmemoFactory;
 
 /**
- * Class CreditmemoLoader
+ * Loader for creditmemo
  *
- * @package Magento\Sales\Controller\Adminhtml\Order
  * @method CreditmemoLoader setCreditmemoId($id)
  * @method CreditmemoLoader setCreditmemo($creditMemo)
  * @method CreditmemoLoader setInvoiceId($id)
@@ -22,6 +22,7 @@
  * @method string getCreditmemo()
  * @method int getInvoiceId()
  * @method int getOrderId()
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class CreditmemoLoader extends DataObject
 {
@@ -129,7 +130,8 @@ protected function _getItemData()
 
     /**
      * Check if creditmeno can be created for order
-     * @param \Magento\Sales\Model\Order $order
+     *
+     * @param Order $order
      * @return bool
      */
     protected function _canCreditmemo($order)
@@ -153,7 +155,9 @@ protected function _canCreditmemo($order)
     }
 
     /**
-     * @param \Magento\Sales\Model\Order $order
+     * Inits invoice
+     *
+     * @param Order $order
      * @return $this|bool
      */
     protected function _initInvoice($order)

app/code/Magento/Sales/Test/Mftf/Test/AdminOpenCreditmemoViewPageWithWrongCreditmemoIdTest.xml

@@ -33,7 +33,6 @@
 
         <seeInCurrentUrl url="{{AdminCreditMemosGridPage.url}}" stepKey="redirectToCreditMemosGridPage"/>
 
-        <see selector="{{AdminMessagesSection.error}}" userInput='This creditmemo no longer exists.'
-             stepKey="seeErrorMessage"/>
+        <actionGroup ref="AssertAdminPageIs404ActionGroup" stepKey="see404PageOnAdmin"/>
     </test>
 </tests>

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Creditmemo/ViewTest.php

@@ -143,9 +143,6 @@ class ViewTest extends TestCase
      */
     protected function setUp(): void
     {
-        $titleMock = $this->getMockBuilder(\Magento\Framework\App\Action\Title::class)
-            ->disableOriginalConstructor()
-            ->getMock();
         $this->invoiceMock = $this->getMockBuilder(Invoice::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -238,9 +235,6 @@ protected function setUp(): void
         $this->contextMock->expects($this->any())
             ->method('getObjectManager')
             ->willReturn($this->objectManagerMock);
-        $this->contextMock->expects($this->any())
-            ->method('getTitle')
-            ->willReturn($titleMock);
         $this->contextMock->expects($this->any())
             ->method('getMessageManager')
             ->willReturn($this->messageManagerMock);
@@ -272,7 +266,7 @@ public function testExecuteNoCreditMemo()
         $this->loaderMock->expects($this->once())
             ->method('load')
             ->willReturn(false);
-        
+
         $this->prepareRedirect();
         $this->setPath('sales/creditmemo');
         $this->assertInstanceOf(

app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Invoice/ViewTest.php

@@ -127,10 +127,6 @@ protected function setUp(): void
             ->disableOriginalConstructor()
             ->setMethods([])
             ->getMock();
-        $this->titleMock = $this->getMockBuilder(\Magento\Framework\App\Action\Title::class)
-            ->disableOriginalConstructor()
-            ->setMethods([])
-            ->getMock();
         $this->viewMock = $this->getMockBuilder(\Magento\Framework\App\View::class)
             ->disableOriginalConstructor()
             ->setMethods([])
@@ -176,9 +172,6 @@ protected function setUp(): void
         $contextMock->expects($this->any())
             ->method('getResponse')
             ->willReturn($this->responseMock);
-        $contextMock->expects($this->any())
-            ->method('getTitle')
-            ->willReturn($this->titleMock);
         $contextMock->expects($this->any())
             ->method('getView')
             ->willReturn($this->viewMock);

app/code/Magento/Shipping/Controller/Adminhtml/Order/ShipmentLoader.php

@@ -18,9 +18,8 @@
 use Magento\Sales\Api\Data\ShipmentItemCreationInterface;
 
 /**
- * Class ShipmentLoader
+ * Loader for shipment
  *
- * @package Magento\Shipping\Controller\Adminhtml\Order
  * @method ShipmentLoader setOrderId($id)
  * @method ShipmentLoader setShipmentId($id)
  * @method ShipmentLoader setShipment($shipment)